fix: design page navigating to settings Page url error #5546
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liweitian
requested review from
a-b-r-o-w-n,
beyackle,
boydc2014,
cwhitten,
GeoffCoxMSFT,
hatpick,
srinaath and
tonyanziano
as code owners
boydc2014
approved these changes
Jan 18, 2021
lei9444
pushed a commit
that referenced
this pull request
Jan 18, 2021
Co-authored-by: Dong Lei <donglei@microsoft.com>
alanlong9278
added a commit
that referenced
this pull request
Jan 25, 2021
* main: Update numberinput.dialog (#5575) fix hover display incorrect returntype (#5588) fix: Move persistence layer's delta computation into worker (#5563) fix: electron update error (#5573) fix: showing correct error message in local publish (#5509) feat: change source of packages from local feed to live npm/nuget feed (#5516) set max http header size to fix 431 (#5521) Updating to daily runtime for R12 development (#5529) fix: correctly generate l10n files when using zsh (#5555) chore: deprecate feature request issue template (#5378) fix: designPage navigation to settings Page url error (#5546) fix: luis\qna key missing in skill bot (#5545) delete trigger by projectId passed from projectTree (#5542)
benbrown
pushed a commit
to benbrown/BotFramework-Composer
that referenced
this pull request
May 24, 2021
Co-authored-by: Dong Lei <donglei@microsoft.com>
benbrown
pushed a commit
that referenced
this pull request
Jun 11, 2021
Co-authored-by: Dong Lei <donglei@microsoft.com>
lei9444
pushed a commit
to lei9444/BotFramework-Composer-1
that referenced
this pull request
Jun 15, 2021
Co-authored-by: Dong Lei <donglei@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
A url bug was introduced in recent Pr. When a skill bot is missing a luis/qna key, we can click on the error and navigate to settings page in Design page project tree. But the navigation url is incorrect. It passed current project id which should be root bot project Id.
Task Item
#minor
Screenshots