Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: showing correct error message in local publish #5509

Merged
merged 6 commits into from
Jan 21, 2021
Merged

Conversation

VanyLaw
Copy link
Contributor

@VanyLaw VanyLaw commented Jan 13, 2021

Description

some error doesn't serializate.

Task Item

close #5390

Screenshots

@coveralls
Copy link

coveralls commented Jan 13, 2021

Coverage Status

Coverage remained the same at 55.086% when pulling 574ee5e on wenyluo/fix5390 into 1aa2c8a on main.

@boydc2014 boydc2014 changed the title fix: showing [object object] in local publish fix: showing correct error message in local publish Jan 21, 2021
@VanyLaw VanyLaw merged commit 1ed31e1 into main Jan 21, 2021
@VanyLaw VanyLaw deleted the wenyluo/fix5390 branch January 21, 2021 07:12
alanlong9278 added a commit that referenced this pull request Jan 25, 2021
* main:
  Update numberinput.dialog (#5575)
  fix hover display incorrect returntype (#5588)
  fix: Move persistence layer's delta computation into worker (#5563)
  fix: electron update error (#5573)
  fix: showing correct error message in local publish (#5509)
  feat: change source of packages from local feed to live npm/nuget feed (#5516)
  set max http header size to fix 431 (#5521)
  Updating to daily runtime for R12 development (#5529)
  fix: correctly generate l10n files when using zsh (#5555)
  chore: deprecate feature request issue template (#5378)
  fix: designPage navigation to settings Page url error (#5546)
  fix: luis\qna key missing in skill bot (#5545)
  delete trigger by projectId passed from projectTree (#5542)
lei9444 pushed a commit to lei9444/BotFramework-Composer-1 that referenced this pull request Jun 15, 2021
* stringify error in local publish

* stringify error by  toString

* fix comment
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bot fails to start after update to v1.3.0
3 participants