fix: keep highlight on item with the menu open #4835
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…otFramework-Composer into feature/bot-projects
…otFramework-Composer into feature/bot-projects
…otFramework-Composer into feature/bot-projects
…otFramework-Composer into feature/bot-projects
…otFramework-Composer into feature/bot-projects
…otFramework-Composer into feature/bot-projects
beyackle
requested review from
a-b-r-o-w-n,
boydc2014,
cwhitten,
GeoffCoxMSFT,
hatpick,
srinaath and
tonyanziano
as code owners
|
I have a try on this, seems on context menu open, current item turn out to be 'selected' style (blue) , not 'hover' style (gray) ,
Is it by design ? |
|
It's possible I misunderstood the issue, and on reading it again, that would make more sense (to keep the gray highlight in place, not the blue one which shows which one is active). I'll change this to do that instead. |
|
A screenshot of the new behavior: The gray highlight now stays in place while the menu is out, even when the cursor moves. |
srinaath
approved these changes
Nov 17, 2020
alanlong9278
added a commit
to alanlong9278/BotFramework-Composer
that referenced
this pull request
Nov 18, 2020
* feature/bot-projects: fix: keep highlight on item with the menu open (microsoft#4835) All tests passed chore: Pull form dialogs feature branch back to main (microsoft#4841) X-platform fix for electron-server "start" script (microsoft#4833) build: add option to force rebuild of extensions (microsoft#4830) fix: remove checkURL call from navTo on dialog clicks (microsoft#4795) fix: export to zip (microsoft#4820) fix: prevent minification of AbortSignal (microsoft#4829) feat: Settings page (microsoft#4456) feat: bot projects skill & context menu (microsoft#4492) fix: repair E2E tests that depended on seeing a single bot name (microsoft#4807) Removed some extraneous characters from the downloaded pva zip name (microsoft#4808) fix: Fixes linux icons on the taskbar (microsoft#4806) Update 1.2.0.md release: 1.2.0 (microsoft#4796) fix: validate bot name when passed via URL params (microsoft#4712) fix async move (microsoft#4799) fix: Await until delete action finishes (microsoft#4792) fix: update debounced update handlers (microsoft#4790)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This adds some logic to the ProjectTree and TreeItem components to let them keep track of which, if any, tree item is selected. This lets us visually "lock" the highlight in place when we have a menu open; if any menu is open, that one will be shown as highlighted. If not, the highlight will be on whichever item is actively shown.
Task Item
closes #4810
Screenshots
(note: my cursor is over on another item during this screenshot)