Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: prevent minification of AbortSignal #4829

Merged
merged 1 commit into from
Nov 16, 2020
Merged

fix: prevent minification of AbortSignal #4829

merged 1 commit into from
Nov 16, 2020

Conversation

boydc2014
Copy link
Contributor

@boydc2014 boydc2014 commented Nov 16, 2020 •
edited
Loading

Update webpackconfig of azure publish plugin to prevent the minification of AbortSignal type

fixes #4716

luhan2017
luhan2017 approved these changes Nov 16, 2020
View reviewed changes
Copy link
Contributor

@luhan2017 luhan2017 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified for azure publish scenario

image

@coveralls
Copy link

Coverage Status

Coverage increased (+0.009%) to 54.786% when pulling d0be4e6 on donglei/fix-webpack into 4caefe5 on main.

@a-b-r-o-w-n a-b-r-o-w-n merged commit bd95360 into main Nov 16, 2020
@a-b-r-o-w-n a-b-r-o-w-n deleted the donglei/fix-webpack branch November 16, 2020 16:46
a-b-r-o-w-n pushed a commit that referenced this pull request Nov 16, 2020
@boydc2014 @a-b-r-o-w-n
fix: prevent minification of AbortSignal (#4829)
9534416
alanlong9278 added a commit to alanlong9278/BotFramework-Composer that referenced this pull request Nov 18, 2020
@alanlong9278
Merge branch 'feature/bot-projects' into julong/publish-page
00890f3 
* feature/bot-projects:
  fix: keep highlight on item with the menu open (microsoft#4835)
  All tests passed
  chore: Pull form dialogs feature branch back to main (microsoft#4841)
  X-platform fix for electron-server "start" script (microsoft#4833)
  build: add option to force rebuild of extensions (microsoft#4830)
  fix: remove checkURL call from navTo on dialog clicks (microsoft#4795)
  fix: export to zip (microsoft#4820)
  fix: prevent minification of AbortSignal (microsoft#4829)
  feat: Settings page (microsoft#4456)
  feat: bot projects skill & context menu (microsoft#4492)
  fix: repair E2E tests that depended on seeing a single bot name (microsoft#4807)
  Removed some extraneous characters from the downloaded pva zip name (microsoft#4808)
  fix: Fixes linux icons on the taskbar (microsoft#4806)
  Update 1.2.0.md
  release: 1.2.0 (microsoft#4796)
  fix: validate bot name when passed via URL params (microsoft#4712)
  fix async move (microsoft#4799)
  fix: Await until delete action finishes (microsoft#4792)
  fix: update debounced update handlers (microsoft#4790)
@boydc2014 boydc2014 restored the donglei/fix-webpack branch November 18, 2020 06:30
benbrown pushed a commit to benbrown/BotFramework-Composer that referenced this pull request May 24, 2021
@boydc2014 @a-b-r-o-w-n
fix: prevent minification of AbortSignal (microsoft#4829)
5d8fb38
benbrown pushed a commit that referenced this pull request Jun 11, 2021
@boydc2014 @a-b-r-o-w-n
fix: prevent minification of AbortSignal (#4829)
93fbc51
lei9444 pushed a commit to lei9444/BotFramework-Composer-1 that referenced this pull request Jun 15, 2021
@boydc2014
fix: prevent minification of AbortSignal (microsoft#4829)
24aa660
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@luhan2017 luhan2017 luhan2017 approved these changes

@a-b-r-o-w-n a-b-r-o-w-n a-b-r-o-w-n approved these changes

@cwhitten cwhitten Awaiting requested review from cwhitten

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Cannot deployed bot run from Azure
4 participants
@boydc2014 @coveralls @a-b-r-o-w-n @luhan2017