feat: Trigger UI Schema #4079
Merged
feat: Trigger UI Schema #4079
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
This was referenced Oct 9, 2020
|
Conflicts resovled and tried on my local machine. |
a-b-r-o-w-n
previously approved these changes
Jan 21, 2021
a-b-r-o-w-n
approved these changes
Jan 27, 2021
yeze322
commented
Jan 27, 2021
Comment on lines
-240
to
-245
| if (schemas && checkForPVASchema(schemas.sdk)) { | ||
| triggerTypeOptions = triggerTypeOptions.filter( | ||
| (elem) => | ||
| elem.text.indexOf('QnA Intent recognized') == -1 && elem.text.indexOf('Duplicated intents recognized') == -1 | ||
| ); | ||
| } |
lei9444
pushed a commit
to lei9444/BotFramework-Composer-1
that referenced
this pull request
Jun 15, 2021
* chore: move TriggerCreationModal to folder * chore: move styles into styles.ts * chore: move validators out * Extract dropdown options as constants * remove outdated dropdown option generators * don't re-declare SDKKinds as type key * remove initialError, fix tslint * fix warning icon size * refactor show warning logic * move static func outside TriggerModal * refactor: move trigger widget out of Modal * replay changes in microsoft#4117 'mutiple projects' * fix a wrong import path * refactor: extract TriggerDropdownGroup * define builtinSchema * TriggerOptionTree * remove duplicated $kinds * link leaf ndoe to parent node * migrate to option tree * fix a React grammar * rename builtinSchema * refactor the warning icon logic of trigger modal * remove unreferenced utils * add a todo * fix UT by adding data-testid * declare TriggerUISchema in extension * use trigger uischema from extension context * check trigger option existence * sort trigger dropdown labels * move root text out of tree utils * pass in option compare fn * add UT for triggerOptionTree * align icon size with main * migrate 1.2 PVA logic * use 'Boolean' to filter trigger menus Co-authored-by: Andy Brown <asbrown002@gmail.com> * wrap trigger UI Schema with formatMessage * add 'px' unit to styles * add trigger menu order * 'order' property to manage trigger order * early returning & add comments * avoid duplicated iteration and add comments * fix trigger modal UT * lint * replay Ben's commit * CI fix Co-authored-by: Chris Whitten <christopher.whitten@microsoft.com> Co-authored-by: Andy Brown <asbrown002@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Special notes for PVA scenario:
In the release of 1.2.1, extra logic was added for PVA environment. There were 2 changes:
For 1, this PR has covered the case;
for 2, to make sure PVA has correct bahavior, the
app.uischemaneeds to be updated as below to disable 2 Triggers:{ "Microsoft.VirtualAgents.Recognizer": { "recognizer": { "displayName": "PVA Recognizer" } }, "Microsoft.OnChooseIntent": { "trigger": false }, "Microsoft.OnQnAMatch": { "trigger": false } }Generate Trigger modal from UI Schema. Preview the schema of Trigger options: builtinTriggerSchema.ts
Customization Instructions
sdk.uischemaPlan
Task Item
closes #2889
Screenshots