Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use ui plugin / ui schema for trigger creation modal #2889

Closed
a-b-r-o-w-n opened this issue May 4, 2020 · 2 comments · Fixed by #4079
Closed

Use ui plugin / ui schema for trigger creation modal #2889

a-b-r-o-w-n opened this issue May 4, 2020 · 2 comments · Fixed by #4079
Assignees
@yeze322
Labels
Team: Platform Type: Engineering
Milestone
R12

Comments

@a-b-r-o-w-n
Copy link
Contributor

a-b-r-o-w-n commented May 4, 2020 •
edited
Loading

related to #2845
@a-b-r-o-w-n a-b-r-o-w-n added Type: Engineering R10 Release 10 - August 17th, 2020 labels May 4, 2020
@a-b-r-o-w-n a-b-r-o-w-n self-assigned this May 4, 2020
@a-b-r-o-w-n a-b-r-o-w-n added R11 Release 11 - November 15th, 2020 and removed R10 Release 10 - August 17th, 2020 labels Jul 21, 2020
@yeze322
Copy link
Contributor

yeze322 commented Jul 22, 2020 •
edited
Loading

During Trigger creation process, the modal UI could be divided into 2 sections:

  1. Hierarchical dropdown menu - to finally drop down to a Trigger $kind.
  2. Properties form / widget - to fill required fields of Trigger data.
    image

Considering that

  1. Similar to the Action fly-out menu, the dropdown menu needs to be configurable and schema driven.
  2. Some Trigger $kinds require extra logic such as validation / LU editor.

It's necessary to treat those 2 sections differently:

  • For section 1, let it be generated from uischema. We translate a Trigger dropdown menu to uischema config, similar to the menu part in uischema.
  • For section 2, let it be a hooked React Component. For example, a plugin implements a React Component and declares that the Component should be hooked to a Trigger $kind and displayed during the Trigger creation process. That Component owns validation / editor logic.

@yeze322 yeze322 mentioned this issue Aug 12, 2020
Closed
2 tasks
@yeze322 yeze322 mentioned this issue Sep 3, 2020
Closed
1 task
@yeze322 yeze322 mentioned this issue Sep 10, 2020
Merged
4 tasks
@cwhitten cwhitten removed the R11 Release 11 - November 15th, 2020 label Oct 1, 2020
@cwhitten cwhitten added this to the R12 milestone Oct 13, 2020
@yeze322
Copy link
Contributor

yeze322 commented Oct 19, 2020 •
edited
Loading

addressd in #4079

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@yeze322 yeze322

Labels
Team: Platform Type: Engineering
Projects
None yet
Milestone
R12
4 participants
@cwhitten @a-b-r-o-w-n @yeze322 @hibrenda