Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: can not capture events in visual editor #2913

Merged
merged 1 commit into from
May 6, 2020
Merged

Conversation

alanlong9278
Copy link
Contributor

@alanlong9278 alanlong9278 commented May 6, 2020

Description

Fixed: can not use event capture in visual editor.

  • Before
    bug-focus-beh

  • After
    capture

After fixed it, the container focused state will be removed when children doms' event triggered.

Why need change the style?

This is because children doms' mouse event will be blocked when container dom has focus::after styles, like below

 &::after {
      content: '';
      position: absolute;
      top: 0;
      bottom: 0;
      left: 0;
      right: 0;
      border: black solid 1px;
    }

So I removed the after styles.

Task Item

fix #2907

Screenshots

@boydc2014
Copy link
Contributor

boydc2014 commented May 6, 2020

This fixed the behavior, but i want to confirm is drawing a border on the whole visual canvas is expected?

@cwhitten @a-b-r-o-w-n did you see a black box on the whole visual on Mac like this ?

image

it feels so significant...

@github-actions
Copy link

github-actions bot commented May 6, 2020

Coverage Status

Coverage remained the same at 0.0% when pulling 3a26cf9 on julong/eventCapture into 70b9715 on master.

@boydc2014 boydc2014 mentioned this pull request May 6, 2020
4 tasks
@yeze322 yeze322 changed the title fix: can not use event capture in visual editor fix: can not capture events in visual editor May 6, 2020
@boydc2014 boydc2014 added the Approved to merge approved, waiting to be merged label May 6, 2020
@cwhitten cwhitten merged commit 4e53c0c into master May 6, 2020
@cwhitten cwhitten deleted the julong/eventCapture branch May 6, 2020 14:07
alanlong9278 added a commit that referenced this pull request May 7, 2020
* master: (58 commits)
  fix: Copy skill manifests to the correct directory in the localPublish plugin (#2932)
  feat: Goto Begin Dialog after clicking dialog (#2922)
  fix: Improved Electron auto update UX (#2925)
  fix: Action Flow gradual left alignment (#2909)
  fix: word wrap in SendActivity (#2908)
  fix: Fixed various onboarding issues and updated content (#2900)
  chore: Component Governance (#2899)
  perf: improve property editor performance (#2921)
  fix: paste blank node (#2905)
  extract memory variables at lg lsp server (#2902)
  feat: manage samples via plugin (#2805)
  can not use event capture in visual editor (#2913)
  style: make focus styles more consistent (#2898)
  feat: azure publish plugin (#2733)
  fix: unable to clear form title (#2885)
  fix: Populate env variable with AppData folder (#2894)
  a11y: use Key/Value aria labels in object field (#2890)
  Fix border issue in visual editor (#2891)
  fix: changes manifest type from '.manifest' to '.json' (#2888)
  Fixed packaged folder structure. (#2887)
  ...
lei9444 pushed a commit to lei9444/BotFramework-Composer-1 that referenced this pull request Jun 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Approved to merge approved, waiting to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants