style: make focus styles more consistent #2898
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
show the skill form in a modal
a-b-r-o-w-n
requested review from
beyackle,
boydc2014,
corinagum,
cwhitten,
srinaath,
tonyanziano and
yeze322
as code owners
cwhitten
approved these changes
May 5, 2020
7 tasks
7 tasks
7 tasks
4 tasks
alanlong9278
added a commit
that referenced
this pull request
May 7, 2020
* master: (58 commits) fix: Copy skill manifests to the correct directory in the localPublish plugin (#2932) feat: Goto Begin Dialog after clicking dialog (#2922) fix: Improved Electron auto update UX (#2925) fix: Action Flow gradual left alignment (#2909) fix: word wrap in SendActivity (#2908) fix: Fixed various onboarding issues and updated content (#2900) chore: Component Governance (#2899) perf: improve property editor performance (#2921) fix: paste blank node (#2905) extract memory variables at lg lsp server (#2902) feat: manage samples via plugin (#2805) can not use event capture in visual editor (#2913) style: make focus styles more consistent (#2898) feat: azure publish plugin (#2733) fix: unable to clear form title (#2885) fix: Populate env variable with AppData folder (#2894) a11y: use Key/Value aria labels in object field (#2890) Fix border issue in visual editor (#2891) fix: changes manifest type from '.manifest' to '.json' (#2888) Fixed packaged folder structure. (#2887) ...
lei9444
pushed a commit
to lei9444/BotFramework-Composer-1
that referenced
this pull request
Jun 15, 2021
* use action button instead of link for more consistent focus style * fix focus outline for visual panel * fix search box focus style * fix visual editor focus style * improve focus styles for dialog nav * fix focus style for main left nav * bring connect skill button into toolbar show the skill form in a modal * fix broken tests * fix focus style in form * remove extra border from visual design container * Fix lint Co-authored-by: Chris Whitten <christopher.whitten@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Improves focus style consistency throughout the app.
Moves the add skill button to the toolbar and the form into a modal.
Task Item
closes #2882
Screenshots