a11y: accessibility issue 2026 #2740
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liweitian
requested review from
a-b-r-o-w-n,
benbrown,
boydc2014,
corinagum,
cwhitten,
luhan2017 and
yeze322
as code owners
beyackle
approved these changes
Apr 23, 2020
There was a problem hiding this comment.
I approve this in general, but I'd really like some feedback about proper table behavior from someone who depends on using a screen-reader. I feel like a good SR should be handling this automatically. That's not a fault of this code, though - just a separate thought.
You can check the info #2640 here. @corinagum described a lot about the right behavior. |
lei9444
pushed a commit
to lei9444/BotFramework-Composer-1
that referenced
this pull request
Jun 15, 2021
* allow accessing table cells and associate them with table header * add aria-label * fix unit test Co-authored-by: Ben Yackley <61990921+beyackle@users.noreply.github.com> Co-authored-by: Chris Whitten <christopher.whitten@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Update code to make lg, lu, recent bot, notification and save as file selector tables' cell associate with table name. And the cell can only be focused through keyboard operation.
Task Item
Refs #2026