Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Accessibility][Labels or Instructions - Save as]: Screen reader does not associate the table labels while reading the table contents. #2026

Closed
ShellySoni opened this issue Feb 20, 2020 · 8 comments

Comments

@ShellySoni
Copy link

ShellySoni commented Feb 20, 2020

User Experience:
Screen reader users will not get proper information and may get difficulty in performing the task efficiently if table Labels are not associated with there respective content.

Test Environment:
Environment: Chromium Edge (Anaheim) + Narrator
Build Version: 2004 (OS Build 19564.1005)​​
Microsoft Edge Version: 82.0.425.0 (Official build) canary (64-bit)​
Test URL: http://localhost:3000/home

Repro Steps:

  1. Open URL: http://localhost:3000/home
  2. Navigate on homepage with tab key up to 'Save as' button and press enter on it.
  3. Observe the issue on table.

Actual Result:
While navigating within table using ctrl+Alt+arrow keys, Screen reader does not associate the table labels i.e. Name, data modified, while reading the table contents.

Note:
This issue is repro on every table throughout this application.

Expected Result:
While navigating within table using ctrl+Alt+arrow keys, Screen reader should associate the table labels i.e. Name, data modified, while reading the table contents.

MAS Reference:
https://microsoft.sharepoint.com/:w:/r/teams/msenable/_layouts/15/WopiFrame.aspx?sourcedoc={4b95a70d-258c-474a-820e-5c8b79d5c0bf}

Attachment:
MAS3.3.2_Save as.zip
MAS3.3.2_Save as _tablecontents.zip

@corinagum
Copy link
Contributor

PR above is a partial fix. @liweitian could you link the bug you filed with the fabric team on this issue for tracking?

@liweitian
Copy link
Contributor

liweitian commented Apr 16, 2020

PR above is a partial fix. @liweitian could you link the bug you filed with the fabric team on this issue for tracking?
@corinagum
microsoft/fluentui#12701. He gives a "solution" https://codepen.io/slimemold/pen/rNOxrjd?editors=0110. But we have to go to row first then go inside to cell. Is this behavior acceptable? You can try it.

@corinagum
Copy link
Contributor

@liweitian thanks for the link. Yes, I think this is a great solution. I don't see any problems with it. :)

@ashish315
Copy link

@cwhitten As checked the fix seems good but the issue is not resolved for every table such as Recent Bot table, Notification etc

@cwhitten
Copy link
Member

cwhitten commented Apr 21, 2020

@ashish315 the bug is for Save As, not Recent Bots or Notification.

@ashish315
Copy link

@cwhitten In the issue, the note section was their according to which issue observed for each and every table.

@liweitian
Copy link
Contributor

@cwhitten In the issue, the note section was their according to which issue observed for each and every table.

Just opened a pr to solve this problem. #2740

@cwhitten cwhitten added the Fixed label Apr 30, 2020
@ashish315
Copy link

As checked issue is resolved, now the narrator narrates descriptive information about table header. So, HCL is closing the bug

@ashish315 ashish315 removed the Fixed label May 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

8 participants