Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DependencyCollector references a bad and old version of System.Data.SqlClient #1351

Closed
ErikEJ opened this issue Aug 1, 2019 · 4 comments
Closed

DependencyCollector references a bad and old version of System.Data.SqlClient #1351

ErikEJ opened this issue Aug 1, 2019 · 4 comments

Comments

@ErikEJ
Copy link

ErikEJ commented Aug 1, 2019

You should update the reference to System.Data.SqlClient to a newer version, you are currently using version 4.3.1 and current version is 4.6.1 - the 4.3.1 version causes issues with newer dependencies - see issue here: dotnet/SqlClient#144
@TimothyMothra
Copy link
Member

Thank you for reporting this.

@lmolkova I feel like I was talking to you about SqlClient recently but I can't remember the context.
Would it be safe to update this version today?

@ErikEJ
Copy link
Author

ErikEJ commented Aug 2, 2019

Event upgrading to the next version after 4.3.1 (4.4.0) fixes the issue.

@TimothyMothra TimothyMothra transferred this issue from microsoft/ApplicationInsights-dotnet-server Dec 4, 2019
@sadjadbp sadjadbp mentioned this issue Dec 27, 2019
Closed
@ErikEJ
Copy link
Author

ErikEJ commented Apr 9, 2020

Ping??

@cijothomas
Copy link
Contributor

dependency on System.Data.SqlClient was removed in the current beta. We can close this issue.

lazcool added a commit to SkillsFundingAgency/dfc-servicetaxonomy-editor that referenced this issue Sep 15, 2020
@lazcool
improve validation results reporting to account for checking all items
c474e02 
+ update application insights (see microsoft/ApplicationInsights-dotnet#1351)
@pragnagopa pragnagopa mentioned this issue Dec 19, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@ErikEJ @cijothomas @TimothyMothra