Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Out of date transient nuget dependencies installed with AspNetCore SDK #1521

Closed
lmolkova opened this issue Dec 27, 2019 · 5 comments
Closed
Labels

Comments

@lmolkova
Copy link
Member

lmolkova commented Dec 27, 2019

Repro Steps

  1. Install .NET Core 3.0 or 3.1 (if you don't have it)
  2. Create an Web API ASP.NET Core web app
  3. install Microsoft.ApplicationInsights.AspNetCore 2.12.0
  4. Here is a list of dependencies VS shows in install dialog

Actual Behavior

Installing:

Microsoft.ApplicationInsights.2.12.0
Microsoft.ApplicationInsights.AspNetCore.2.12.0
Microsoft.ApplicationInsights.DependencyCollector.2.12.0
Microsoft.ApplicationInsights.EventCounterCollector.2.12.0
Microsoft.ApplicationInsights.PerfCounterCollector.2.12.0
Microsoft.ApplicationInsights.WindowsServer.2.12.0
Microsoft.ApplicationInsights.WindowsServer.TelemetryChannel.2.12.0
Microsoft.AspNetCore.Hosting.1.0.2
Microsoft.AspNetCore.Hosting.Abstractions.1.0.2
Microsoft.AspNetCore.Hosting.Server.Abstractions.1.0.2
Microsoft.AspNetCore.Http.1.0.2
Microsoft.AspNetCore.Http.Abstractions.1.0.2
Microsoft.AspNetCore.Http.Extensions.1.0.2
Microsoft.AspNetCore.Http.Features.1.0.2
Microsoft.AspNetCore.WebUtilities.1.0.2
Microsoft.Extensions.Caching.Abstractions.1.0.0
Microsoft.Extensions.Caching.Memory.1.0.0
Microsoft.Extensions.Configuration.2.1.0
Microsoft.Extensions.Configuration.Abstractions.2.1.0
Microsoft.Extensions.Configuration.Binder.2.1.0
Microsoft.Extensions.Configuration.EnvironmentVariables.1.0.2
Microsoft.Extensions.Configuration.FileExtensions.2.1.0
Microsoft.Extensions.Configuration.Json.2.1.0
Microsoft.Extensions.DependencyInjection.1.0.2
Microsoft.Extensions.DependencyInjection.Abstractions.2.1.0
Microsoft.Extensions.DiagnosticAdapter.1.1.0
Microsoft.Extensions.FileProviders.Abstractions.2.1.0
Microsoft.Extensions.FileProviders.Physical.2.1.0
Microsoft.Extensions.FileSystemGlobbing.2.1.0
Microsoft.Extensions.Logging.2.1.0
Microsoft.Extensions.Logging.Abstractions.2.1.0
Microsoft.Extensions.Logging.ApplicationInsights.2.12.0
Microsoft.Extensions.ObjectPool.1.0.1
Microsoft.Extensions.Options.2.1.0
Microsoft.Extensions.PlatformAbstractions.1.1.0
Microsoft.Extensions.Primitives.2.1.0
Microsoft.Net.Http.Headers.1.0.2
Microsoft.NETCore.Platforms.2.0.0
Microsoft.NETCore.Targets.1.1.0
Microsoft.Win32.Primitives.4.3.0
Microsoft.Win32.Registry.4.5.0
NETStandard.Library.1.6.1
Newtonsoft.Json.11.0.2
runtime.debian.8-x64.runtime.native.System.Security.Cryptography.OpenSsl.4.3.0
runtime.fedora.23-x64.runtime.native.System.Security.Cryptography.OpenSsl.4.3.0
runtime.fedora.24-x64.runtime.native.System.Security.Cryptography.OpenSsl.4.3.0
runtime.native.System.4.3.0
runtime.native.System.Data.SqlClient.sni.4.3.0
runtime.native.System.IO.Compression.4.3.0
runtime.native.System.Net.Http.4.3.0
runtime.native.System.Net.Security.4.3.0
runtime.native.System.Security.Cryptography.Apple.4.3.0
runtime.native.System.Security.Cryptography.OpenSsl.4.3.0
runtime.opensuse.13.2-x64.runtime.native.System.Security.Cryptography.OpenSsl.4.3.0
runtime.opensuse.42.1-x64.runtime.native.System.Security.Cryptography.OpenSsl.4.3.0
runtime.osx.10.10-x64.runtime.native.System.Security.Cryptography.Apple.4.3.0
runtime.osx.10.10-x64.runtime.native.System.Security.Cryptography.OpenSsl.4.3.0
runtime.rhel.7-x64.runtime.native.System.Security.Cryptography.OpenSsl.4.3.0
runtime.ubuntu.14.04-x64.runtime.native.System.Security.Cryptography.OpenSsl.4.3.0
runtime.ubuntu.16.04-x64.runtime.native.System.Security.Cryptography.OpenSsl.4.3.0
runtime.ubuntu.16.10-x64.runtime.native.System.Security.Cryptography.OpenSsl.4.3.0
runtime.win7-x64.runtime.native.System.Data.SqlClient.sni.4.3.0
runtime.win7-x86.runtime.native.System.Data.SqlClient.sni.4.3.0
System.AppContext.4.3.0
System.Buffers.4.3.0
System.Collections.4.3.0
System.Collections.Concurrent.4.3.0
System.Collections.Immutable.1.3.0
System.ComponentModel.4.3.0
System.Configuration.ConfigurationManager.4.5.0
System.Console.4.3.0
System.Data.Common.4.3.0
System.Data.SqlClient.4.3.1
System.Diagnostics.Contracts.4.0.1
System.Diagnostics.Debug.4.3.0
System.Diagnostics.DiagnosticSource.4.6.0
System.Diagnostics.PerformanceCounter.4.5.0
System.Diagnostics.StackTrace.4.3.0
System.Diagnostics.Tools.4.3.0
System.Diagnostics.Tracing.4.3.0
System.Globalization.4.3.0
System.Globalization.Calendars.4.3.0
System.Globalization.Extensions.4.3.0
System.IO.4.3.0
System.IO.Compression.4.3.0
System.IO.Compression.ZipFile.4.3.0
System.IO.FileSystem.4.3.0
System.IO.FileSystem.AccessControl.4.5.0
System.IO.FileSystem.Primitives.4.3.0
System.IO.Pipes.4.3.0
System.Linq.4.3.0
System.Linq.Expressions.4.3.0
System.Memory.4.5.0
System.Net.Http.4.3.0
System.Net.NameResolution.4.3.0
System.Net.Primitives.4.3.0
System.Net.Security.4.3.0
System.Net.Sockets.4.3.0
System.Net.WebSockets.4.0.0
System.ObjectModel.4.3.0
System.Private.DataContractSerialization.4.3.0
System.Reflection.4.3.0
System.Reflection.Emit.4.3.0
System.Reflection.Emit.ILGeneration.4.3.0
System.Reflection.Emit.Lightweight.4.3.0
System.Reflection.Extensions.4.3.0
System.Reflection.Metadata.1.4.1
System.Reflection.Primitives.4.3.0
System.Reflection.TypeExtensions.4.3.0
System.Resources.ResourceManager.4.3.0
System.Runtime.4.3.0
System.Runtime.CompilerServices.Unsafe.4.5.0
System.Runtime.Extensions.4.3.0
System.Runtime.Handles.4.3.0
System.Runtime.InteropServices.4.3.0
System.Runtime.InteropServices.RuntimeInformation.4.3.0
System.Runtime.Numerics.4.3.0
System.Runtime.Serialization.Json.4.3.0
System.Runtime.Serialization.Primitives.4.3.0
System.Security.AccessControl.4.5.0
System.Security.Claims.4.3.0
System.Security.Cryptography.Algorithms.4.3.0
System.Security.Cryptography.Cng.4.3.0
System.Security.Cryptography.Csp.4.3.0
System.Security.Cryptography.Encoding.4.3.0
System.Security.Cryptography.OpenSsl.4.3.0
System.Security.Cryptography.Primitives.4.3.0
System.Security.Cryptography.ProtectedData.4.5.0
System.Security.Cryptography.X509Certificates.4.3.0
System.Security.Permissions.4.5.0
System.Security.Principal.4.3.0
System.Security.Principal.Windows.4.5.0
System.Text.Encoding.4.3.0
System.Text.Encoding.CodePages.4.3.0
System.Text.Encoding.Extensions.4.3.0
System.Text.Encodings.Web.4.3.1
System.Text.RegularExpressions.4.3.0
System.Threading.4.3.0
System.Threading.Overlapped.4.3.0
System.Threading.Tasks.4.3.0
System.Threading.Tasks.Extensions.4.3.0
System.Threading.Thread.4.3.0
System.Threading.ThreadPool.4.3.0
System.Threading.Timer.4.3.0
System.Xml.ReaderWriter.4.3.0
System.Xml.XDocument.4.3.0
System.Xml.XmlDocument.4.3.0
System.Xml.XmlSerializer.4.3.0

Expected Behavior

It does not seem right that on 3.X we depend

  • on any of System.* 4.3.0 packages
  • on AspNet packages 1.0.X
  • on Extensions packages 2.X
@lmolkova lmolkova changed the title A top of out of date transient nuget dependencies installed with AspNetCore SDK Out of date transient nuget dependencies installed with AspNetCore SDK Dec 27, 2019
@cijothomas
Copy link
Contributor

Is this because we don't have a netstandard2.1 target?

@sadjadbp
Copy link

somehow should have been fixed as part of

microsoft/ApplicationInsights-dotnet-server#1269
microsoft/ApplicationInsights-dotnet-server#1263
microsoft/ApplicationInsights-dotnet-server#1249
#1351

it causes dotnet/SqlClient#144

@lmolkova
Copy link
Member Author

lmolkova commented Dec 27, 2019

@cijothomas I guess we need 3.1 target and conditionally need to reference proper versions.

@sadjadbp I don't think it has any effect on runtime - actual version of dependencies used are determined by your application target framework.

@sadjadbp
Copy link

@lmolkova no affect on runtime but as mentioned dotnet/SqlClient#144 you'll get build error and to fix you have to add direct dependency to latest version of SqlClient like below. So your project file would have dependency to both Microsoft.Data.SqlClient and System.Data.SqlClient (just code ugliness for now)

<PackageReference Include="System.Data.SqlClient" Version="4.8.0" />

@github-actions
Copy link

This issue is stale because it has been open 300 days with no activity. Remove stale label or comment or this will be closed in 7 days.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants