Skip to content
This repository has been archived by the owner on Jul 5, 2020. It is now read-only.

Ignore unobserved task exceptions explicitly marked as observed #1024

Merged
merged 3 commits into from
Jun 18, 2019
Merged

Ignore unobserved task exceptions explicitly marked as observed #1024

merged 3 commits into from
Jun 18, 2019

Conversation

i3arnon
Copy link
Contributor

@i3arnon i3arnon commented Oct 2, 2018

Fixes #1026

This allows users to ignore specific exceptions (for example, from third party libraries) by subscribing to UnobservedTaskException and marking the exceptions as observed via UnobservedTaskExceptionEventArgs.SetObserved.

Without this users need to remove the entire UnobservedExceptionTelemetryModule in order to ignore floods of uninteresting exceptions outside their control.

  • I ran Unit Tests locally.

@SergeyKanzhelev
Copy link
Contributor

Can you please create an issue with the description of the change and the use example. It will work as a documentation for the feature on GitHub,

Also - update CHANGELOG.md with the reference to that issue.

Thank you for contribution!

@msftclas
Copy link

msftclas commented Oct 2, 2018

CLA assistant check
All CLA requirements met.

@i3arnon
Copy link
Contributor Author

i3arnon commented Nov 6, 2018

@SergeyKanzhelev ping?

@cijothomas
Copy link
Contributor

@SergeyKanzhelev Can we merge this?

@SergeyKanzhelev
Copy link
Contributor

@cijothomas I left a comment. Please decide. Good feature, I would recommend to enhance it with the config setting to restore the original behavior.

@cijothomas
Copy link
Contributor

@i3arnon Can you make a public bool field on the module, and Ignore the exception based on its value?
If you are not actively working on this, please let us know - I will merge this, as it is for now, and add the public bool field as a followup PR.

Thanks for your contribution!

@cijothomas cijothomas merged commit 1f50be7 into microsoft:develop Jun 18, 2019
@i3arnon i3arnon deleted the observed-task-exception branch June 29, 2019 13:02
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow users to ignore specific UnobservedTaskExceptions
4 participants