Ignore unobserved task exceptions explicitly marked as observed (#1024)

* Ignore unobserved task exceptions explicitly marked as observed
microsoft · Jun 18, 2019 · 1f50be7 · 1f50be7
1 parent bb0064a
commit 1f50be7
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 0 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -56,6 +56,7 @@
 	If you are upgrading, and have added/modified TelemetryProcessors, make sure to copy them to the default sink section.
 - [Microsoft.AspNet.TelemetryCorrelaiton package update to 1.0.4](https://github.com/Microsoft/ApplicationInsights-dotnet-server/issues/991)
 - Add vmScaleSetName field to heartbeat properties collected by AzureInstanceMetadataTelemetryModule to allow navigation to right Azure VM Scale Set
+- [Allow users to ignore specific UnobservedTaskExceptions](https://github.com/Microsoft/ApplicationInsights-dotnet-server/issues/1026)
 
 ## Version 2.8.0-beta1
 - [Adds opt-in support for W3C distributed tracing standard](https://github.com/Microsoft/ApplicationInsights-dotnet-server/pull/945)

diff --git a/Src/WindowsServer/WindowsServer.Shared/UnobservedExceptionTelemetryModule.cs b/Src/WindowsServer/WindowsServer.Shared/UnobservedExceptionTelemetryModule.cs
@@ -71,6 +71,11 @@ public void Dispose()
 
         private void TaskSchedulerOnUnobservedTaskException(object sender, UnobservedTaskExceptionEventArgs unobservedTaskExceptionEventArgs)
         {
+            if (unobservedTaskExceptionEventArgs.Observed)
+            {
+                return;
+            }
+
             WindowsServerEventSource.Log.TaskSchedulerOnUnobservedTaskException();
 
             var exp = new ExceptionTelemetry(unobservedTaskExceptionEventArgs.Exception)