Update smoke tests and fix Kafka running locally #2460
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trask
force-pushed
the
update-smoke-tests
branch
from
350d229
to
2534f10
Compare
trask
force-pushed
the
update-smoke-tests
branch
from
2534f10
to
506ccd2
Compare
trask
force-pushed
the
update-smoke-tests
branch
from
506ccd2
to
10f5755
Compare
jeanbisutti
reviewed
Aug 23, 2022
| @@ -192,7 +192,7 @@ public static class Instrumentation { | |||
|
|
|||
| public EnabledByDefaultInstrumentation azureSdk = new EnabledByDefaultInstrumentation(); | |||
| public EnabledByDefaultInstrumentation cassandra = new EnabledByDefaultInstrumentation(); | |||
| public EnabledByDefaultInstrumentation jdbc = new EnabledByDefaultInstrumentation(); | |||
| public JdbcInstrumentation jdbc = new JdbcInstrumentation(); | |||
There was a problem hiding this comment.
It seems possible to make the fields final. It may be converted into constants and the Instrumentation class could be an interface or the class could own a private constructor.
There was a problem hiding this comment.
sorry, this code change is part of #2453, this PR is built on top of that one, and I forgot to set the target branch for it to reflect, will rebase this PR after that one is approved/merged
heyams
approved these changes
Aug 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.