Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to OpenTelemetry 1.17.0 #2453

Merged
merged 11 commits into from
Aug 23, 2022
Merged

Update to OpenTelemetry 1.17.0 #2453

merged 11 commits into from
Aug 23, 2022

Conversation

trask
Copy link
Member

@trask trask commented Aug 19, 2022

Includes a fix for role name and ikey overrides.

Also adds new config for upstream option:

{
  "instrumentation": {
    "jdbc": {
      "masking": {
        "enabled": false
      }
    }
  }
}

Resolves #1989 (disabling the jdbc masking)

@trask trask marked this pull request as ready for review August 19, 2022 23:23
@trask trask mentioned this pull request Aug 21, 2022
@trask
Copy link
Member Author

trask commented Aug 22, 2022

Search and fix 2 issues:

TODO (trask) delete after updating to 1.17.0

@heyams
Copy link
Contributor

heyams commented Aug 23, 2022

Search and fix 2 issues:

TODO (trask) delete after updating to 1.17.0

will you fix these in this PR?

@trask
Copy link
Member Author

trask commented Aug 23, 2022

will you fix these in this PR?

done

@trask trask merged commit d0e442b into main Aug 23, 2022
@trask trask deleted the update-otel branch August 23, 2022 22:10
@asos-jitu
Copy link

2022-08-31 14:18:12.815+01:00 WARN c.m.a.a.i.c.ConfigurationBuilder - Unrecognized field "masking" (class com.microsoft.applicationinsights.agent.internal.configuration.Configuration$EnabledByDefaultInstrumentation), not marked as ignorable (one known property: "enabled"])
at [Source: (sun.nio.ch.ChannelInputStream); line: 15, column: 19] (through reference chain: com.microsoft.applicationinsights.agent.internal.configuration.Configuration["instrumentation"]->com.microsoft.applicationinsights.agent.internal.configuration.Configuration$Instrumentation["jdbc"]->com.microsoft.applicationinsights.agent.internal.configuration.Configuration$EnabledByDefaultInstrumentation["masking"])
2

Got following error with 3.3.1 agent version and "jdbc": {
"masking": {
"enabled": false
}
} config

@trask
Copy link
Member Author

trask commented Aug 31, 2022

hi @asos-jitu! you will need to use 3.4.0-BETA for this new feature: https://github.com/microsoft/ApplicationInsights-Java/releases/tag/3.4.0-BETA

@asos-jitu
Copy link

The masking enables option should be available for all db.types and not only jdbc. Not working for a mongo type and is failing while starting with the following error

2022-09-02 12:27:20.134+01:00 WARN c.m.a.a.i.c.ConfigurationBuilder - Unrecognized field "masking" (class com.microsoft.applicationinsights.agent.internal.configuration.Configuration$EnabledByDefaultInstrumentation), not marked as ignorable (one known property: "enabled"])
at [Source: UNKNOWN; byte offset: #UNKNOWN] (through reference chain: com.microsoft.applicationinsights.agent.internal.configuration.Configuration["instrumentation"]->com.microsoft.applicationinsights.agent.internal.configuration.Configuration$Instrumentation["mongo"]->com.microsoft.applicationinsights.agent.internal.configuration.Configuration$EnabledByDefaultInstrumentation["masking"])
com.fasterxml.jackson.databind.exc.UnrecognizedPropertyException: Unrecognized field "masking" (class com.microsoft.applicationinsights.agent.internal.configuration.Configuration$EnabledByDefaultInstrumentation), not marked as ignorable (one known property: "enabled"])
at [Source: UNKNOWN; byte offset: #UNKNOWN] (through reference chain: com.microsoft.applicationinsights.agent.internal.configuration.Configuration["instrumentation"]->com.microsoft.applicationinsights.agent.internal.configuration.Configuration$Instrumentation["mongo"]->com.microsoft.applicationinsights.agent.internal.configuration.Configuration$EnabledByDefaultInstrumentation["masking"])

@trask
Copy link
Member Author

trask commented Sep 2, 2022

hi @asos-jitu! can you open a new issue so we can track this? the current configuration option only applies to jdbc, but we should be able to add a similar configuration option to mongo

@asos-jitu
Copy link

Hi @trask I have raised an issue for Mongo type, please take a look.
2498

@asos-jitu
Copy link

Hi @trask any dates for releasing the 3.4.0-BETA version?

@trask
Copy link
Member Author

trask commented Sep 7, 2022

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Get SQL Command params
3 participants