-
Notifications
You must be signed in to change notification settings - Fork 199
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix App Map display of unknown dependencies #1716
Conversation
@@ -322,6 +322,20 @@ private void applySemanticConventions(SpanData span, RemoteDependencyTelemetry r | |||
applyServiceBusSpan(attributes, remoteDependencyData); | |||
return; | |||
} | |||
|
|||
String target = getTargetFromPeerAttributes(attributes, -1); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
defaultPort = 0?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have seen other places using 0.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
and added clarifying comment
* Fix App Map display of unknown dependencies * Add net peer mapping to target also * Add clarifying comment
* Support agentmain (#1687) * Use ProfilerEndpoint from connection string (#1694) * Add test to make sure no non-daemon threads (#1695) * Better EventHubs support (#1698) * Reduce spammy error (#1701) * Emit Profiler start/stop events (#1706) * 2.x SDK explicit operation id / operation parent id should take precedence (#1708) * Support explicit operation id/parentId from 2.x * Test * Release 3.1.1-BETA.2 (#1709) * Prepare for a new beta release * Fix a typo * Reword Co-authored-by: Trask Stalnaker <trask.stalnaker@gmail.com> * Hide super advanced feature. Co-authored-by: Trask Stalnaker <trask.stalnaker@gmail.com> Co-authored-by: Trask Stalnaker <trask.stalnaker@gmail.com> * Better Azure Service Bus support (#1710) * Use main as the default branch from now on (#1715) * Retry webflux tests 3 times when it's failing (#1712) * Retry webflux 3 times when it's failing * print stack trace when the final retry fails * Reword Co-authored-by: Trask Stalnaker <trask.stalnaker@gmail.com> Co-authored-by: Trask Stalnaker <trask.stalnaker@gmail.com> * Update to latest OTel (#1719) * Update OTel * Suppress 2.x request name handler * Remove retry * Suppress CDS Profile endpoint warning in smoke tests * Bump timeout to avoid sporadic failures * Prepare 3.1.1-BETA.3 release (#1723) * Fix App Map display of unknown dependencies (#1716) * Fix App Map display of unknown dependencies * Add net peer mapping to target also * Add clarifying comment * Fix agent jar size (#1724) * Fix agent jar size * Bump version * Add roleName to profile metadata (#1725) * add a unique id for GC events so that events from a single JVM can be grouped (#1721) * Fix 2.x interop of timestamps (#1726) * Fix 2.x interop of timestamps * Add smoke test * Bump version * add logprocessor to agent (#1713) * add logprocessor to agent * comments addressed, added smoketest for log processor, fixed bug in telemetryprocessorOpenTelemetryConfigurer * StringBuffer -> StringBuilder * addressing comments * removed lognames, fixed smoke test * replace name with body in log processor, address comments Co-authored-by: Trask Stalnaker <trask.stalnaker@gmail.com> Co-authored-by: John Oliver <1615532+johnoliver@users.noreply.github.com> Co-authored-by: Helen Y <56097766+heyams@users.noreply.github.com> Co-authored-by: kryalama <66494519+kryalama@users.noreply.github.com>
No description provided.