Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test to make sure no non-daemon threads #1695

Merged
merged 1 commit into from
May 19, 2021
Merged

Conversation

trask
Copy link
Member

@trask trask commented May 19, 2021

No description provided.

@heyams
Copy link
Contributor

heyams commented May 19, 2021

@trask can you provide some context for this smoke test?

@trask
Copy link
Member Author

trask commented May 19, 2021

If we create any non-daemon threads, the agent will prevent an application from terminating normally at the end of main

dependencies {
implementation group: 'org.springframework.boot', name: 'spring-boot-starter-web', version: '2.1.7.RELEASE'

implementation group: 'com.squareup.okhttp3', name: 'okhttp', version: '3.12.1'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we place okhttp version in dependencies.gradle? It's used in two other places.

ext.testAppArtifactFilename = jar.archiveFileName.get()

dependencies {
implementation group: 'org.springframework.boot', name: 'spring-boot-starter-web', version: '2.1.7.RELEASE'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

version in dependencies.gradle?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's consider this in a different PR, there's some benefit to testing against older and different versions

@trask trask merged commit 78d77ce into master May 19, 2021
@trask trask deleted the non-daemon-threads branch May 19, 2021 23:43
heyams added a commit that referenced this pull request Jun 8, 2021
* Support agentmain (#1687)

* Use ProfilerEndpoint from connection string (#1694)

* Add test to make sure no non-daemon threads (#1695)

* Better EventHubs support (#1698)

* Reduce spammy error (#1701)

* Emit Profiler start/stop events (#1706)

* 2.x SDK explicit operation id / operation parent id should take precedence (#1708)

* Support explicit operation id/parentId from 2.x

* Test

* Release 3.1.1-BETA.2 (#1709)

* Prepare for a new beta release

* Fix a typo

* Reword

Co-authored-by: Trask Stalnaker <trask.stalnaker@gmail.com>

* Hide super advanced feature.

Co-authored-by: Trask Stalnaker <trask.stalnaker@gmail.com>

Co-authored-by: Trask Stalnaker <trask.stalnaker@gmail.com>

* Better Azure Service Bus support (#1710)

* Use main as the default branch from now on (#1715)

* Retry webflux tests 3 times when it's failing (#1712)

* Retry webflux 3 times when it's failing

* print stack trace when the final retry fails

* Reword

Co-authored-by: Trask Stalnaker <trask.stalnaker@gmail.com>

Co-authored-by: Trask Stalnaker <trask.stalnaker@gmail.com>

* Update to latest OTel (#1719)

* Update OTel

* Suppress 2.x request name handler

* Remove retry

* Suppress CDS Profile endpoint warning in smoke tests

* Bump timeout to avoid sporadic failures

* Prepare 3.1.1-BETA.3 release (#1723)

* Fix App Map display of unknown dependencies (#1716)

* Fix App Map display of unknown dependencies

* Add net peer mapping to target also

* Add clarifying comment

* Fix agent jar size (#1724)

* Fix agent jar size

* Bump version

* Add roleName to profile metadata (#1725)

* add a unique id for GC events so that events from a single JVM can be grouped (#1721)

* Fix 2.x interop of timestamps (#1726)

* Fix 2.x interop of timestamps

* Add smoke test

* Bump version

* add logprocessor to agent (#1713)

* add logprocessor to agent

* comments addressed, added smoketest for log processor, fixed bug in telemetryprocessorOpenTelemetryConfigurer

* StringBuffer -> StringBuilder

* addressing comments

* removed lognames, fixed smoke test

* replace name with body in log processor, address comments

Co-authored-by: Trask Stalnaker <trask.stalnaker@gmail.com>

Co-authored-by: John Oliver <1615532+johnoliver@users.noreply.github.com>
Co-authored-by: Helen Y <56097766+heyams@users.noreply.github.com>
Co-authored-by: kryalama <66494519+kryalama@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants