Avoid unnecessary string copies #4201
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chriche-ms
changed the title
shalinijoshi19
added
the
Area-Performance
ghost
added
the
|
Hi @chriche-ms. This non-spec pull request has had no recent activity for the past 5 days . Please take the necessary actions (review, address feedback or commit if reviewed already) to move this along. |
|
Hi @shalinijoshi19; Thanks for reviewing this previously stale pull request. Resetting staleness. @chriche-ms FYI. |
|
@RebeccaAnne is added to the review. #Closed |
|
@paulcam206 is added to the review. #Closed |
…thub.com/chriche-ms/AdaptiveCards into chriche/uwp_performance_stringconversion
rankush
pushed a commit
to rankush/AdaptiveCards
that referenced
this pull request
May 8, 2024
* Improve performance of utf8 <-> utf16 conversion code * Small tweaks to UWP string conversion functions * Remove unnecessary string conversions * Remove unnecessary string copies * Update various functions to return strings by reference Co-authored-by: Paul Campbell <paulcam@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue
Fixes #4198
Description
Updates various C++ functions to accept and/or return strings by reference (const-ref and r-value) to avoid unnecessary string copies. Also makes minor tweaks to the UTF-8 <-> UTF-16 string conversion code. These changes aim to improve card parsing and rendering performance.
How Verified
Ran the existing unit tests and performed manual testing by parsing and rendering a number of adaptive cards used by the Cortana in Windows app.
Microsoft Reviewers: Open in CodeFlow