Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[UWP] Unnecessary string copying #4198

Closed
chriche-ms opened this issue Jun 19, 2020 · 2 comments · Fixed by #4201
Closed

[UWP] Unnecessary string copying #4198

chriche-ms opened this issue Jun 19, 2020 · 2 comments · Fixed by #4201
Labels
Area-Performance Tracking issues around perf/renderer latency etc Bug
Milestone
1.3 Schema Refresh

Comments

@chriche-ms
Copy link
Member

Platform

  • Android
  • iOS
  • UWP

Author or host

Author and host. Cortana in Windows - app is both an author and host.

Version of SDK

NuGet 1.2.8

Details

Many C++ functions accept std::string parameters by value when they should really be by const-ref or r-value ref. Updating the parameter types would help improve performance by reducing the number of string copies made during parsing and rendering.
@chriche-ms chriche-ms added the Bug label Jun 19, 2020
@ghost ghost added the Triage-Needed label Jun 19, 2020
@chriche-ms chriche-ms mentioned this issue Jun 22, 2020
Merged
@shalinijoshi19 shalinijoshi19 added this to the 20.06 milestone Jun 22, 2020
@shalinijoshi19 shalinijoshi19 added Area-Performance Tracking issues around perf/renderer latency etc and removed AdaptiveCards v1.2.10 labels Jun 22, 2020
@shalinijoshi19
Copy link
Member

@paulcam206 / @RebeccaAnne to help review this and shepherd it into main where it can bake for a bit until we push out the July refresh.

@ghost
Copy link

ghost commented Aug 6, 2020

🎉AdaptiveCards@2020.07 has been released which fixes this issue.:tada:

Handy links:

@microsoft microsoft deleted a comment Aug 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Area-Performance Tracking issues around perf/renderer latency etc Bug
Projects
None yet
Milestone
1.3 Schema Refresh
Development

Successfully merging a pull request may close this issue.

Avoid unnecessary string copies chriche-ms/AdaptiveCards
4 participants
@RebeccaAnne @paulcam206 @shalinijoshi19 @chriche-ms