Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(feat) add Localstack SNS #639

Merged
merged 3 commits into from
Jun 19, 2024

Conversation

lucjross-favor
Copy link
Contributor

@lucjross-favor lucjross-favor commented Jun 7, 2024

This adds a Localstack SNS provider.

I tried to create a test for subscription & notification functionality that used a test HTTP controller, but that proved difficult for Docker/host networking reasons. The test now just makes sure that the create-topic operation works.

@lucjross-favor lucjross-favor reopened this Jun 7, 2024
@lucjross-favor
Copy link
Contributor Author

Also, (a) is this the right branch to merge into? and (b) could you say how soon this could go into a release?

Thanks!

@lucjross-favor
Copy link
Contributor Author

Execution failed for task ':micronaut-test-resources-localstack-sns:findBaseline'.

Could not find a previous version for 2.6.0

How do I fix this?

@lucjross-favor
Copy link
Contributor Author

Hi @melix , could you advise on the above? 🙏

@graemerocher graemerocher requested a review from melix June 16, 2024 07:13
@melix
Copy link
Collaborator

melix commented Jun 17, 2024

How do I fix this?

You need to add:

micronautBuild {
    binaryCompatibility {
        enabledAfter '2.6.0'
    }
}

in the new module's build.gradle file

@melix melix merged commit 504224f into micronaut-projects:2.6.x Jun 19, 2024
6 checks passed
@melix
Copy link
Collaborator

melix commented Jun 19, 2024

Thanks for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants