Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Artwork transition error in AM 2.5.0 #499

Closed
randombyt opened this issue Nov 9, 2018 · 12 comments
Closed

Artwork transition error in AM 2.5.0 #499

randombyt opened this issue Nov 9, 2018 · 12 comments

Comments

@randombyt
Copy link

In AM 2.5.0 version if an artwork/ image doesn't exist instead of showing an empty space, which was the norm in prior versions, last available image is shown. The trigger being used is "Transition.EndNavigation".

OS: win 8.1 x64

@oomek
Copy link
Collaborator

oomek commented Nov 9, 2018

I'm aware of this bug and I have it fixed, but the PR will come in a couple more days, as I'm struggling with health issues atm. There will be a new option in settings to show nothing or a No Image Available image if the artwork is missing. It can be set to show this image for all missing files, just for dynamic artwork, and never show it, just a blank image as before. I hope it will be useful to easy scan the library for missing images.

@randombyt
Copy link
Author

Thanks for the prompt reply, I hope you feel better soon. The coming upgrades sound great. I already put up a feature request for layout-wide place-holders, this will take care of that issue perfectly.

@oomek
Copy link
Collaborator

oomek commented Nov 9, 2018

The default artwork is not an image, but it's constructed from primitives. Does this default artwork look ok, or would you rather have the ability to override it with a png loaded from some yet undefined location?

attract mode screenshot 2018 11 09 - 21 07 15 05

@randombyt
Copy link
Author

Default artwork is looking good but I was hoping for an option for custom over-ride png so layout color scheme is retained. Since "no image available" is not an image, would it be possible to modify it? chnage the background and text color?

@mickelson
Copy link
Owner

mickelson commented Nov 10, 2018

looks cool, my preference is to have a default ‘no image available’ png loaded from the config directory. If that default isn’t there because it was removed by the user, then preserve the current intended behaviour (a blank).

@oomek
Copy link
Collaborator

oomek commented Nov 10, 2018

After looking at the image today I saw it overlystyled, I swapped it with a simpler one, and when there is an image default.png in AM folder it's used instead. I decided to go with more neutral one and stuff it inside a header file converted with bin2c. The default placeholder should not be dependant on any file in my opinion. I still think that an option in settings is neccessary to allow the placeholder be visible for different types of images and configurable. Some themes (hyperspin.nut?) are codded in a way that if placeholder enabled for everything it would show a big mess, not just on an artwork. (I'l upload a video to describe what I have in mind.

@oomek
Copy link
Collaborator

oomek commented Nov 10, 2018

https://youtu.be/rMSejvBsoXw
give it 5-10 min until it's uploaded and processed in 1080p

@mickelson
Copy link
Owner

Hi Oomek, the fix for this issue needs to restore the old behaviour as the default (blank if no image found). users shouldn’t have to do anything extra to get back the original and correct behaviour when they copy the new exe into their setup. we shouldn’t purposely breaki things for users who want to upgrade. adding support for a user supplied ‘no image’ file is fine as an additional feature, but to be consistent with the overall fe design it shouldn’t be built into the executable, it should go in the config dir so the user can freely change it, just like with all other images and resources.

@oomek
Copy link
Collaborator

oomek commented Nov 10, 2018

The old method conflicts with the new image loading and it has a huge flaw when you bind a texture to the shader and suddenly it evaporates. Some people just copy the exe to upgrade, hence the need of embedding a default image placeholder in the exe. But don't worry the default option will be set to not show the placeholder of course but instead a transparent 1x1px image, so the behaviour is consistent with the old version and the shaders are working fine on missing artwork. On the video I showed you 2 of 3 modes. The default does not show a placeholder. I hope it's clear now.

@oomek
Copy link
Collaborator

oomek commented Nov 10, 2018

So the setting's name I've just added is Missing Image Placeholders
and the available values are as follows:

  • Hide All
  • Show All
  • Only Artwork
  • Only Static
  • Only Magic Tokens

The default value is set to Hide All, the rest is for developers and pack builders to easily find missing files in their collections, and figure out what kind of image it is. Would that be acceptable?

@oomek
Copy link
Collaborator

oomek commented Nov 11, 2018

Is this behaviour seems acceptable to you Andrew?
https://youtu.be/yzjo1MnVci4

mickelson added a commit that referenced this issue Nov 13, 2018
Recent changes inadvertently introduced this bug.  Committing this in
prep for a patch release 2.5.1
@randombyt
Copy link
Author

The issue is resolved in AM 2.5.1, thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants