Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: Layout-wide place-holder artwork #500

Closed
randombyt opened this issue Nov 9, 2018 · 6 comments
Closed

Feature Request: Layout-wide place-holder artwork #500

randombyt opened this issue Nov 9, 2018 · 6 comments

Comments

@randombyt
Copy link

Right now an artwork named after romlist acts as a place holder, this requires to create additional files even if the artwork being used is same in every case, e,g. simple snap saying missing artwork.

It would be great if we can create layout-wide place-holders. Romlist specific place-holders can over-ride layout specific place-holders keeping everything intact.

@oomek
Copy link
Collaborator

oomek commented Nov 9, 2018

It's been already implemented in my wip branch which I'm about to push. The details explained in the following issue
#499 (comment)

@randombyt
Copy link
Author

In case of romlist placeholders we can make an image in each artwork folder (snap, title, video etc). How would that work in "Missing Image Placeholders"? Will there be a single image applicable to all artwork classes or one image for each artwork class?

@oomek
Copy link
Collaborator

oomek commented Nov 16, 2018

The main idea behind it is that you have a default image placeholder embedded in exe that applies to any type of static image, magic token or artwork that is missing. It's not layout wide but application wide. By default it's off. You enable it for the time you are gathering your artwork collection and during construction of a layout, to make sure you don't have any elements with empty filename not hidden and floating around. It additionally fixes the null references in the shaders when you use set_texture_param()

@mickelson
Copy link
Owner

mickelson commented Nov 16, 2018 via email

@oomek
Copy link
Collaborator

oomek commented Nov 16, 2018

So to fix the null references in shaders I just make a 1x1 transparent snap.png and stick it into the layout folder?

@randombyt
Copy link
Author

randombyt commented Nov 16, 2018

Thank you, that is exactly what I was looking for. I didn't knew AM already has the layout-wide placeholders in place. I just checked and 'layout/layout-name/artwork.png works as expected.

closing the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants