-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a Typescript declaration file #7
Conversation
Oh awesome! Thanks, I'll have a look at this sometime in the next couple of days |
Alright, removed the declaration tag at the top, and rebased to the current master! |
@mhart Okay to merge? 😄 |
Hey @mhart any chance of getting this merged? |
@mhart Happy to be a resource to help keep this maintained. I've been using this definition since last last year without issues. |
Likewise, I was excited to see this referenced in the recent Cloudflare blog post, and am using these TypeScript definitions. |
Hey all – sorry for the radio silence – tough times. I actually wanted to get this happening with JSDoc comments, but I got sidetracked. I'll get this in and then move to that – thanks! |
Released as 1.0.6 – thanks again @Electroid for the contribution 🙌 |
Woo! Thank you @mhart!! |
I might have done something wrong but when I copied these types into my project I had to rename |
I ended up implementing the JSDoc solution and have republished the types in 1.0.7 Let me know if there are any problems! |
Ugh, yeah the module name is a problem. Pity typescript didn't pick that up from any of the tests within the repo itself. Thanks for the PR @blakeembrey – this has been fixed in v1.0.9 |
@mhart I have created a PR #60 to fix the issue. |
Closes #6 by adding a Typescript declaration file.