Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TypeScript interfaces (definition files) #6

Closed
MickL opened this issue Dec 5, 2019 · 3 comments · Fixed by #7
Closed

TypeScript interfaces (definition files) #6

MickL opened this issue Dec 5, 2019 · 3 comments · Fixed by #7

Comments

@MickL
Copy link

MickL commented Dec 5, 2019

Could you please add interfaces for TypeScript? Currently everything is undefined/unknown.
@mhart
Copy link
Owner

mhart commented Dec 5, 2019

I don't use TypeScript for this project – but feel free to create a PR and I'll check it out 👍

@MickL
Copy link
Author

MickL commented Dec 5, 2019

Problem is that i am not as much into the functions and what they need and return. I think only the developer can do this properly.

@Electroid Electroid mentioned this issue Dec 10, 2019
Merged
@mhart mhart closed this as completed in #7 May 20, 2020
@marcogrcr
Copy link

@MickL I don't believe you did anything wrong. I have submitted a new pull request to address this (and other issues), as well as add types testing (#16).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add a Typescript declaration file
3 participants
@mhart @marcogrcr @MickL