-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add spellchecker prow test for website repo #624
add spellchecker prow test for website repo #624
Conversation
/override test-ubuntu-integration-main |
@tuminoid: Overrode contexts on behalf of tuminoid: test-ubuntu-integration-main In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
LGTM |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/hold |
We earlier removed yaspeller that worked via pre-commit hook. This replaces the spellchecking using basically the same dictionary, but using node/npx cspell to do the spell checking. Actual spellcheck script is done in PR metal3-io/metal3-io.github.io#391 Signed-off-by: Tuomo Tanskanen <tuomo.tanskanen@est.tech>
ea85974
to
8517513
Compare
Updated to use |
/override test-ubuntu-integration-main |
@tuminoid: Overrode contexts on behalf of tuminoid: test-ubuntu-integration-main In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kashifest The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/cc @lentzi90 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
All flags in both PRs are there, lets merge this one. |
@tuminoid: Updated the
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
We earlier removed yaspeller that worked via pre-commit hook. This replaces the spellchecking using basically the same dictionary, but using node/npx cspell to do the spell checking.
Actual spellcheck script is done in PR
metal3-io/metal3-io.github.io#391
This should be merged first, so we can test the check in the target repo.