Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add cspell as new spell checker #391

Merged
merged 1 commit into from
Jan 26, 2024
Merged

add cspell as new spell checker #391

merged 1 commit into from
Jan 26, 2024

Conversation

tuminoid
Copy link
Member

Add cspell as spell checker to replace yaspeller that was removed earlier.

Word list from yaspeller ignore list added back as is, and the new or remaining spell checking issues fixed.

@netlify Netlify
Copy link

netlify bot commented Jan 25, 2024 •
edited
Loading

✅ Deploy Preview for metal3io-website ready!

Name Link
🔨 Latest commit 1948012
🔍 Latest deploy log https://app.netlify.com/sites/metal3io-website/deploys/65b37bf236674600084234f8
😎 Deploy Preview https://deploy-preview-391--metal3io-website.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

tuminoid added a commit to Nordix/metal3-project-infra that referenced this pull request Jan 25, 2024
@tuminoid
add spellchecker prow test for website repo
ea85974 
We earlier removed yaspeller that worked via pre-commit hook. This
replaces the spellchecking using basically the same dictionary, but
using node/npx cspell to do the spell checking.

Actual spellcheck script is done in PR
metal3-io/metal3-io.github.io#391

Signed-off-by: Tuomo Tanskanen <tuomo.tanskanen@est.tech>
@metal3-io-bot metal3-io-bot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Jan 25, 2024
@tuminoid tuminoid mentioned this pull request Jan 25, 2024
Merged
@tuminoid
Copy link
Member Author

/hold
Needs metal3-io/project-infra#624 to merge first.

@metal3-io-bot metal3-io-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 25, 2024
kashifest
kashifest reviewed Jan 25, 2024
View reviewed changes
hack/spellcheck.sh Outdated Show resolved Hide resolved
@tuminoid tuminoid force-pushed the tuomo/add-spell-checker branch from 3d2dcb1 to 324d144 Compare January 25, 2024 13:35
tuminoid added a commit to Nordix/metal3-project-infra that referenced this pull request Jan 25, 2024
@tuminoid
add spellchecker prow test for website repo
8517513 
We earlier removed yaspeller that worked via pre-commit hook. This
replaces the spellchecking using basically the same dictionary, but
using node/npx cspell to do the spell checking.

Actual spellcheck script is done in PR
metal3-io/metal3-io.github.io#391

Signed-off-by: Tuomo Tanskanen <tuomo.tanskanen@est.tech>
@tuminoid
Copy link
Member Author

tuminoid commented Jan 25, 2024 •
edited
Loading

Updated per @kashifest suggestion to use cspell-cli image. Much smaller image to download.

@kashifest
Copy link
Member

/approve

@kashifest
Copy link
Member

/lgtm

@metal3-io-bot
Copy link
Contributor

@kashifest: adding LGTM is restricted to approvers and reviewers in OWNERS files.

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@kashifest
Copy link
Member

Can't add a label but thanks for the update and the PR itself.

@maxrantil
Copy link

LGTM

@tuminoid
Copy link
Member Author

/cc @Rozzii
/assign @lentzi90

@metal3-io-bot metal3-io-bot requested a review from Rozzii January 25, 2024 13:47
lentzi90
lentzi90 reviewed Jan 26, 2024
View reviewed changes
Copy link
Member

@lentzi90 lentzi90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@metal3-io-bot metal3-io-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 26, 2024
Rozzii
Rozzii previously approved these changes Jan 26, 2024
View reviewed changes
Copy link
Member

@Rozzii Rozzii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@metal3-io-bot metal3-io-bot added the lgtm Indicates that a PR is ready to be merged. label Jan 26, 2024
@metal3-io-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kashifest, lentzi90, Rozzii

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tuminoid
Copy link
Member Author

/retest
Spellcheck should trigger now.

@tuminoid
add cspell as new spell checker
1948012 
Add cspell as spell checker to replace yaspeller that was removed
earlier.

Word list from yaspeller ignore list added back as is, and the new or
remaining spell checking issues fixed.

Signed-off-by: Tuomo Tanskanen <tuomo.tanskanen@est.tech>
@tuminoid tuminoid force-pushed the tuomo/add-spell-checker branch from 324d144 to 1948012 Compare January 26, 2024 09:31
@metal3-io-bot metal3-io-bot removed the lgtm Indicates that a PR is ready to be merged. label Jan 26, 2024
@Rozzii
Copy link
Member

Rozzii commented Jan 26, 2024

/lgtm

@metal3-io-bot metal3-io-bot added the lgtm Indicates that a PR is ready to be merged. label Jan 26, 2024
@kashifest
Copy link
Member

why do I see two spellcheck jobs here ?

@tuminoid
Copy link
Member Author

why do I see two spellcheck jobs here ?

sHellcheck and sPellcheck :)

@kashifest
Copy link
Member

why do I see two spellcheck jobs here ?

sHellcheck and sPellcheck :)

Oh my my, I need my glasses

@tuminoid
Copy link
Member Author

/unhold
Good to go.

@metal3-io-bot metal3-io-bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 26, 2024
@metal3-io-bot metal3-io-bot merged commit ecd4871 into metal3-io:source Jan 26, 2024
10 checks passed
@metal3-io-bot metal3-io-bot deleted the tuomo/add-spell-checker branch January 26, 2024 09:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lentzi90 lentzi90 lentzi90 left review comments

@kashifest kashifest kashifest left review comments

@Rozzii Rozzii Rozzii left review comments

Assignees

@lentzi90 lentzi90

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@tuminoid @kashifest @metal3-io-bot @maxrantil @Rozzii @lentzi90