Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make BMO e2e prow job required #621

Merged
merged 1 commit into from
Jan 19, 2024
Merged

Make BMO e2e prow job required #621

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 9 additions & 10 deletions prow/manifests/overlays/metal3/config.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -138,11 +138,7 @@ branch-protection:
[
"test-centos-e2e-integration-main",
"test-ubuntu-integration-main",
"metal3-bmo-e2e-test",
]
release-0.5:
required_status_checks:
contexts: ["metal3-bmo-e2e-test"]
cluster-api-provider-metal3:
branches:
main:
Expand Down Expand Up @@ -245,11 +241,6 @@ jenkins_operators:
- max_concurrency: 150
max_goroutines: 20
job_url_template: 'https://jenkins.nordix.org/view/Metal3/job/{{.Spec.Job}}/{{.Status.JenkinsBuildID}}/'
report_templates:
"*": >-
[Full PR test history](https://prow.apps.test.metal3.io/pr-history?org={{.Spec.Refs.Org}}&repo={{.Spec.Refs.Repo}}&pr={{with index .Spec.Refs.Pulls 0}}{{.Number}}{{end}}).
[Your PR dashboard](https://prow.apps.test.metal3.io/pr?query=is:pr+state:open+author:{{with
index .Spec.Refs.Pulls 0}}{{.Author}}{{end}}).

periodics:
- name: periodic-stale
Expand Down Expand Up @@ -542,7 +533,15 @@ presubmits:
agent: jenkins
# Don't run unless triggered to avoid wasting resources
always_run: false
# Until we have checked that it works, keep it optional
optional: false
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What do you think? Should we trigger it automatically instead but have

skip_if_only_changed: '(((^|/)OWNERS)|(\.md))$'

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is the way to go. We've spent quite a lot of time developing the e2e test to make BMO testing more standalone, and its rather fast and stable test, so why wouldn't we want to run it?

- name: metal3-bmo-e2e-test-optional-pull
# E2e tests do not exist before release-0.5
branches:
- main
- release-0.5
agent: jenkins
# Don't run unless triggered to avoid wasting resources
always_run: false
optional: true

metal3-io/cluster-api-provider-metal3:
Expand Down
Loading