Make BMO e2e prow job required

[lentzi90]

This removes the required status context for BMO e2e tests and instead makes the prow job required.

It also removes the report template because this is already covered by the report template set for plank. This config is currently causing double messages when a job fails (one for jenkins and one for plank).

One thing to discuss, test and decide is how to handle these required jobs.
Other required jobs that we have run automatically when needed. The e2e jobs have traditionally been manually triggered only to save some resources. I'm not sure if a required but not automatically run job will show up in the status contexts. If not, we have to decide if we

1. Add required status contexts back for them, or
2. Run the jobs automatically. If we choose this we can also use config like "skip if only" to not run it on all PRs, which would be quite nice!

[lentzi90]

What do you think? Should we trigger it automatically instead but have

skip_if_only_changed: '(((^|/)OWNERS)|(\.md))$'

[tuminoid]

I think this is the way to go. We've spent quite a lot of time developing the e2e test to make BMO testing more standalone, and its rather fast and stable test, so why wouldn't we want to run it?

[Rozzii]

/approve

[lentzi90]

/hold
@Rozzii what do you think about changing it to use skip_if_only_changed?

[tuminoid]

/approve

[metal3-io-bot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Rozzii, tuminoid

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [tuminoid]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[Rozzii]

/hold @Rozzii what do you think about changing it to use skip_if_only_changed?

If the regexp works and it correctly skips the md and the OWNER files then I am fine with it.

[Rozzii]

/lgtm

[Rozzii]

/test-ubuntu-integration-main

[lentzi90]

After offline discussion, I think we can keep the old behavior of manual trigger but required job.
After merging this I will check if we need the required status check or not and do a follow up PR if needed.
/hold cancel

[metal3-io-bot]

@lentzi90: Updated the config configmap in namespace prow at cluster default using the following files:

• key config.yaml using file prow/manifests/overlays/metal3/config.yaml

In response to this:

This removes the required status context for BMO e2e tests and instead makes the prow job required.

It also removes the report template because this is already covered by the report template set for plank. This config is currently causing double messages when a job fails (one for jenkins and one for plank).

One thing to discuss, test and decide is how to handle these required jobs.
Other required jobs that we have run automatically when needed. The e2e jobs have traditionally been manually triggered only to save some resources. I'm not sure if a required but not automatically run job will show up in the status contexts. If not, we have to decide if we

1. Add required status contexts back for them, or
2. Run the jobs automatically. If we choose this we can also use config like "skip if only" to not run it on all PRs, which would be quite nice!

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.