Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove yaspeller #381

Merged
merged 1 commit into from
Jan 11, 2024
Merged

remove yaspeller #381

merged 1 commit into from
Jan 11, 2024

Conversation

tuminoid
Copy link
Member

@tuminoid tuminoid commented Jan 9, 2024

Combined that yaspeller does not work (#378 #379 #380) and how yaspeller works that it is uploading all the content to Russia into Yandex API for spellcheck. This could lead to leaking of sensitive information. Remove it.

TODO: find another spellcheck tool later.

@tuminoid
remove yaspeller
4aa8ba7 
yaspeller does not work and it is uploading all the content to Russia
into Yandex API for spellcheck. This could lead to leaking of
sensitive information.

Signed-off-by: Tuomo Tanskanen <tuomo.tanskanen@est.tech>
@netlify Netlify
Copy link

netlify bot commented Jan 9, 2024 •
edited
Loading

✅ Deploy Preview for metal3io-website ready!

Name Link
🔨 Latest commit 4aa8ba7
🔍 Latest deploy log https://app.netlify.com/sites/metal3io-website/deploys/659cf83cd46ba700082ef325
😎 Deploy Preview https://deploy-preview-381--metal3io-website.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@metal3-io-bot metal3-io-bot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Jan 9, 2024
lentzi90
lentzi90 reviewed Jan 9, 2024
View reviewed changes
Copy link
Member

@lentzi90 lentzi90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure what sensitive content it would upload that wouldn't anyway be published on github or a webpage, but it is a pain...
/approve

@metal3-io-bot metal3-io-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 9, 2024
@mquhuy
Copy link
Member

mquhuy commented Jan 9, 2024

Should we find a replacement first?

@tuminoid
Copy link
Member Author

tuminoid commented Jan 9, 2024

Not sure what sensitive content it would upload that wouldn't anyway be published on github or a webpage, but it is a pain... /approve

Not an issue when its running in CI obviously, but running locally, you might end up sending over files you shouldn't. The defaults of course are not dangerous, but you can feed it any file, bad pattern etc.

@tuminoid
Copy link
Member Author

tuminoid commented Jan 9, 2024

Should we find a replacement first?

It doesn't work, so it is only a risk right now. We can find alternative later.

@tuminoid tuminoid mentioned this pull request Jan 9, 2024
Closed
@tuminoid
Copy link
Member Author

tuminoid commented Jan 9, 2024

/cc @Rozzii

@metal3-io-bot metal3-io-bot requested a review from Rozzii January 9, 2024 08:14
Rozzii
Rozzii approved these changes Jan 11, 2024
View reviewed changes
Copy link
Member

@Rozzii Rozzii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@metal3-io-bot metal3-io-bot added the lgtm Indicates that a PR is ready to be merged. label Jan 11, 2024
@metal3-io-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lentzi90, Rozzii

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@metal3-io-bot metal3-io-bot merged commit e97cfc3 into metal3-io:source Jan 11, 2024
7 checks passed
@metal3-io-bot metal3-io-bot deleted the tuomo/remove-yaspeller branch January 11, 2024 06:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lentzi90 lentzi90 lentzi90 left review comments

@Rozzii Rozzii Rozzii approved these changes

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@tuminoid @mquhuy @metal3-io-bot @lentzi90 @Rozzii