Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update yaspeller to latest version #379

Merged
merged 1 commit into from
Jan 8, 2024

Conversation

mquhuy
Copy link
Member

@mquhuy mquhuy commented Jan 8, 2024

We are using way too old yaspeller version, which caused issue #378

Copy link

netlify bot commented Jan 8, 2024

Deploy Preview for metal3io-website ready!

Name Link
🔨 Latest commit 16b28e9
🔍 Latest deploy log https://app.netlify.com/sites/metal3io-website/deploys/659bef29f314590008fe4f79
😎 Deploy Preview https://deploy-preview-379--metal3io-website.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@metal3-io-bot metal3-io-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jan 8, 2024
@tuminoid
Copy link
Member

tuminoid commented Jan 8, 2024

Cool finding. Now it has some whitespace issue tho, it is suggesting to fix almost every word with " word" (ie. added leading space)... another config issue?

Typos: 1
1. In (suggest:  In)

@mquhuy mquhuy force-pushed the mquhuy/upgrade-yaspeller branch 2 times, most recently from 372669e to 395e4a2 Compare January 8, 2024 10:05
.yaspeller.json Outdated Show resolved Hide resolved
@mquhuy mquhuy force-pushed the mquhuy/upgrade-yaspeller branch from 395e4a2 to 69d41a5 Compare January 8, 2024 11:23
@tuminoid
Copy link
Member

tuminoid commented Jan 8, 2024

It seems to pass in CI (says "Passed" in th log), but it seems to care which files are edited. So if I edit a readme to get yaspeller triggered, it still explodes.

yaspeller................................................................Failed
- hook id: yaspeller
- exit code: 1

/home/tumi/.cache/pre-commit/repoz9kpkrkq/node_env-system/lib/node_modules/yaspeller/node_modules/minimatch/dist/cjs/ast.js:86
    #fillNegs() {
             ^

SyntaxError: Unexpected token '('
    at wrapSafe (internal/modules/cjs/loader.js:915:16)
    at Module._compile (internal/modules/cjs/loader.js:963:27)
    at Object.Module._extensions..js (internal/modules/cjs/loader.js:1027:10)
    at Module.load (internal/modules/cjs/loader.js:863:32)
    at Function.Module._load (internal/modules/cjs/loader.js:708:14)
    at Module.require (internal/modules/cjs/loader.js:887:19)
    at require (internal/modules/cjs/helpers.js:74:18)
    at Object.<anonymous> (/home/tumi/.cache/pre-commit/repoz9kpkrkq/node_env-system/lib/node_modules/yaspeller/node_modules/minimatch/dist/cjs/index.js:9:18)
    at Module._compile (internal/modules/cjs/loader.js:999:30)
    at Object.Module._extensions..js (internal/modules/cjs/loader.js:1027:10)

Does it do same for you, if you edit readme.md and then try commit it, or is it just on my system?

@mquhuy mquhuy force-pushed the mquhuy/upgrade-yaspeller branch from 69d41a5 to b2ad1db Compare January 8, 2024 12:31
@mquhuy
Copy link
Member Author

mquhuy commented Jan 8, 2024

``

It seems to pass in CI (says "Passed" in th log), but it seems to care which files are edited. So if I edit a readme to get yaspeller triggered, it still explodes.

yaspeller................................................................Failed
- hook id: yaspeller
- exit code: 1

/home/tumi/.cache/pre-commit/repoz9kpkrkq/node_env-system/lib/node_modules/yaspeller/node_modules/minimatch/dist/cjs/ast.js:86
    #fillNegs() {
             ^

SyntaxError: Unexpected token '('
    at wrapSafe (internal/modules/cjs/loader.js:915:16)
    at Module._compile (internal/modules/cjs/loader.js:963:27)
    at Object.Module._extensions..js (internal/modules/cjs/loader.js:1027:10)
    at Module.load (internal/modules/cjs/loader.js:863:32)
    at Function.Module._load (internal/modules/cjs/loader.js:708:14)
    at Module.require (internal/modules/cjs/loader.js:887:19)
    at require (internal/modules/cjs/helpers.js:74:18)
    at Object.<anonymous> (/home/tumi/.cache/pre-commit/repoz9kpkrkq/node_env-system/lib/node_modules/yaspeller/node_modules/minimatch/dist/cjs/index.js:9:18)
    at Module._compile (internal/modules/cjs/loader.js:999:30)
    at Object.Module._extensions..js (internal/modules/cjs/loader.js:1027:10)

Does it do same for you, if you edit readme.md and then try commit it, or is it just on my system?

I made a trial in this PR: I added a line in README, but the test still passed. It passed for me locally as well.
Did you do something more special in your edit?

Signed-off-by: Huy Mai <huy.mai@est.tech>
@mquhuy mquhuy force-pushed the mquhuy/upgrade-yaspeller branch from b2ad1db to 16b28e9 Compare January 8, 2024 12:48
Copy link
Member

@tuminoid tuminoid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Must be some glitch in my env then.

/lgtm

@metal3-io-bot metal3-io-bot added the lgtm Indicates that a PR is ready to be merged. label Jan 8, 2024
@tuminoid
Copy link
Member

tuminoid commented Jan 8, 2024

/assign @lentzi90

Copy link
Member

@lentzi90 lentzi90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@metal3-io-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lentzi90

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@metal3-io-bot metal3-io-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 8, 2024
@metal3-io-bot metal3-io-bot merged commit c675e7e into metal3-io:source Jan 8, 2024
7 checks passed
@metal3-io-bot metal3-io-bot deleted the mquhuy/upgrade-yaspeller branch January 8, 2024 13:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants