-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update yaspeller to latest version #379
Update yaspeller to latest version #379
Conversation
✅ Deploy Preview for metal3io-website ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Cool finding. Now it has some whitespace issue tho, it is suggesting to fix almost every word with " word" (ie. added leading space)... another config issue? Typos: 1
1. In (suggest: In) |
372669e
to
395e4a2
Compare
395e4a2
to
69d41a5
Compare
It seems to pass in CI (says "Passed" in th log), but it seems to care which files are edited. So if I edit a readme to get yaspeller triggered, it still explodes. yaspeller................................................................Failed
- hook id: yaspeller
- exit code: 1
/home/tumi/.cache/pre-commit/repoz9kpkrkq/node_env-system/lib/node_modules/yaspeller/node_modules/minimatch/dist/cjs/ast.js:86
#fillNegs() {
^
SyntaxError: Unexpected token '('
at wrapSafe (internal/modules/cjs/loader.js:915:16)
at Module._compile (internal/modules/cjs/loader.js:963:27)
at Object.Module._extensions..js (internal/modules/cjs/loader.js:1027:10)
at Module.load (internal/modules/cjs/loader.js:863:32)
at Function.Module._load (internal/modules/cjs/loader.js:708:14)
at Module.require (internal/modules/cjs/loader.js:887:19)
at require (internal/modules/cjs/helpers.js:74:18)
at Object.<anonymous> (/home/tumi/.cache/pre-commit/repoz9kpkrkq/node_env-system/lib/node_modules/yaspeller/node_modules/minimatch/dist/cjs/index.js:9:18)
at Module._compile (internal/modules/cjs/loader.js:999:30)
at Object.Module._extensions..js (internal/modules/cjs/loader.js:1027:10) Does it do same for you, if you edit readme.md and then try commit it, or is it just on my system? |
69d41a5
to
b2ad1db
Compare
``
I made a trial in this PR: I added a line in README, but the test still passed. It passed for me locally as well. |
Signed-off-by: Huy Mai <huy.mai@est.tech>
b2ad1db
to
16b28e9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Must be some glitch in my env then.
/lgtm
/assign @lentzi90 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: lentzi90 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
We are using way too old yaspeller version, which caused issue #378