CB-380: "Write a review" error messages don't give any context #305
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are two things about the issue in question:-
Not a valid choice issue. This occurs because of the default value of the Flask Validator. However, the specific message that should be displayed for the validation failure has an extra Not a Valid Choice message. I checked the WTF forms docs and they recommend that
InputRequired
be used unless there is a specific reason to useDataRequired
. Using,InputRequired
also fixes the issue.However, there are other places in the codebase where
DataRequired
is used. Do we want to change those toInputRequired
as well ?Changing the exclamation to period is simple. But a livegrep shows ! are used at quite a few places. Do we want to change them as well, if yes which ones ?
JIRA: CB-380