Make changes to fix CB-380

metabrainz · Sep 22, 2020 · 3f52856 · 3f52856
1 parent dd20a41
commit 3f52856
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/critiquebrainz/frontend/forms/review.py b/critiquebrainz/frontend/forms/review.py
@@ -41,7 +41,7 @@ class ReviewEditForm(FlaskForm):
             ('CC BY-SA 3.0', lazy_gettext('Allow commercial use of this review(<a href="https://creativecommons.org/licenses/by-sa/3.0/" target="_blank">CC BY-SA 3.0 license</a>)')),  # noqa: E501
             ('CC BY-NC-SA 3.0', lazy_gettext('Do not allow commercial use of this review, unless approved by MetaBrainz Foundation (<a href="https://creativecommons.org/licenses/by-nc-sa/3.0/" target="_blank">CC BY-NC-SA 3.0 license</a>)')),  # noqa: E501
         ],
-        validators=[validators.DataRequired(message=lazy_gettext("You need to choose a license!"))])
+        validators=[validators.InputRequired(message=lazy_gettext("You need to choose a license!"))])
     remember_license = BooleanField(lazy_gettext("Remember this license choice for further preference"))
     language = SelectField(lazy_gettext("You need to accept the license agreement!"), choices=languages)
     rating = IntegerField(lazy_gettext("Rating"), widget=Input(input_type='number'), validators=[validators.Optional()])

diff --git a/critiquebrainz/frontend/views/review.py b/critiquebrainz/frontend/views/review.py
@@ -231,7 +231,7 @@ def create(entity_type=None, entity_id=None):
     review = reviews[0] if count != 0 else None
 
     if review:
-        flash.error(gettext("You have already published a review for this entity!"))
+        flash.error(gettext("You have already published a review for this entity."))
         return redirect(url_for('review.entity', id=review["id"]))
 
     if current_user.is_review_limit_exceeded: