Fix - static class attributes are not rendered underlined

[SteffenLm]

📑 Summary

This PR fixes the incorrect rendering of static class attributes in a class diagram.

Resolves #5009

📏 Design Decisions

It just fixes the regular expression which was wrong. Now it detects the right characters ('$' and '*').

📋 Tasks

Make sure you

• 📖 have read the contribution guidelines
• 💻 have added necessary unit/e2e tests.
• 📓 have added documentation. Make sure MERMAID_RELEASE_VERSION is used for all new features.
• 🔖 targeted develop branch

Please let me know if i missed something!

[netlify]

✅ Deploy Preview for mermaid-js ready!

Name	Link
🔨 Latest commit	b5fd8fb
🔍 Latest deploy log	https://app.netlify.com/sites/mermaid-js/deploys/6545518ac3092900087da290
😎 Deploy Preview	https://deploy-preview-5013--mermaid-js.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify site configuration.

[codecov]

Codecov Report

Merging #5013 (b5fd8fb) into develop (f5bd1e0) will increase coverage by 37.20%.
The diff coverage is 100.00%.

Additional details and impacted files

@@             Coverage Diff              @@
##           develop    #5013       +/-   ##
============================================
+ Coverage    42.94%   80.14%   +37.20%     
============================================
  Files           23      164      +141     
  Lines         4972    13820     +8848     
  Branches        21      693      +672     
============================================
+ Hits          2135    11076     +8941     
+ Misses        2836     2595      -241     
- Partials         1      149      +148     

Flag	Coverage Δ
e2e	86.19% <100.00%> (?)
unit	42.94% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files	Coverage Δ
packages/mermaid/src/diagrams/class/classTypes.ts	93.47% <100.00%> (ø)

... and 159 files with indirect coverage changes

[SteffenLm]

@jgreywolf thanks for approving the PR but who can merge it?

[sidharthv96]

Nice work with the PR, love the tests.
Would prefer to let @knsv decide regarding removing ?.

[knsv]

Let's do it!

[aloisklink]

Looks good to me too!

I think the merge failed due to a random/flakey test, so retrying it should hopefully fix it.

Edit: Ah, it's cool to see that you work at Airbus Immenstaad, I also used to work there :)

[mermaid-bot]

@SteffenLm, Thank you for the contribution!
You are now eligible for a year of Premium account on MermaidChart.
Sign up with your GitHub account to activate.

[SteffenLm]

Looks good to me too!

I think the merge failed due to a random/flakey test, so retrying it should hopefully fix it.

Edit: Ah, it's cool to see that you work at Airbus Immenstaad, I also used to work there :)

What a pitty. I like to work with colleagues outside the company ;) let's stay in contact :)