Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Class attributes marked as static ($) don't render text-decoration: underline #5009

Closed
SteffenLm opened this issue Nov 3, 2023 · 2 comments · Fixed by #5013
Closed

Class attributes marked as static ($) don't render text-decoration: underline #5009

SteffenLm opened this issue Nov 3, 2023 · 2 comments · Fixed by #5013
Assignees
Labels
Graph: Class Status: Approved Is ready to be worked on Type: Bug / Error Something isn't working or is incorrect

Comments

@SteffenLm
Copy link
Contributor

SteffenLm commented Nov 3, 2023

Description

Class diagrams with static attributes marked with '$' do not render as underlined.
This is can be reproduced in the live editor with the example below.
Methods which are marked as static with the '$' symbol or methods which are marked as abstract with the '*' symbol are rendered correctly. Attributes which are marked as abstract with the '*' are also rendered correctly. However Attributes which are marked as static with the '$' symbol are not rendered correctly. the text-decoration: underline is missing.

Steps to reproduce

Open the following Link in the Live Editor

Screenshots

No response

Code Sample

classDiagram
    class Example {
        - String firstName$
        - String lastName*        
        - firstName: String$
        - lastName: String*
        - getFirstName() String $
        - getLastName() String *
    }

Setup

  • Mermaid version: 10
  • Browser and Version: [Chrome-117.0.5938.150, Edge-117.0.2045.60]

Suggested Solutions

No response

Additional Context

No response

@SteffenLm SteffenLm added Status: Triage Needs to be verified, categorized, etc Type: Bug / Error Something isn't working or is incorrect labels Nov 3, 2023
@jgreywolf jgreywolf added Status: Approved Is ready to be worked on Graph: Class and removed Status: Triage Needs to be verified, categorized, etc labels Nov 5, 2023
@jgreywolf jgreywolf self-assigned this Nov 5, 2023
@SteffenLm
Copy link
Contributor Author

SteffenLm commented Nov 7, 2023

Hey there,
did someone check the issue and the provided pull request? Can I help somehow? @sidharthv96

@SteffenLm
Copy link
Contributor Author

@sidharthv96 @jgreywolf what can I do? Can it be merged soon? I don't have any rights to do anything. Could one of you assist?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Graph: Class Status: Approved Is ready to be worked on Type: Bug / Error Something isn't working or is incorrect
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants