Run action controller load hook only once

[redtachyons]

Rails execute action_controller onload hooks for Both ActionController::Base and ActionController::API.

Rails introduced has_one option to limit executions to one

This will fix #173 for rails 5.1.4 and above

[tute]

Wonderful, thank you! 😃

Would you please include the context in the PR description as part of the commit message? After that, will merge on green CI. Yay!! 🎉

[redtachyons]

Will try, my English is poor

[tute]

Current PR description is good enough! :-)

[tute]

Rails 5.1 seems to fail on CI:

/home/travis/build/merit-gem/merit/vendor/bundle/ruby/2.3.0/gems/railties-5.1.0/lib/rails/test_unit/minitest_plugin.rb:9:in `aggregated_results': wrong number of arguments (given 1, expected 0) (ArgumentError)
	from /home/travis/build/merit-gem/merit/vendor/bundle/ruby/2.3.0/gems/minitest-5.10.3/lib/minitest.rb:597:in `report'
	from /home/travis/build/merit-gem/merit/vendor/bundle/ruby/2.3.0/gems/minitest-5.10.3/lib/minitest.rb:687:in `each'
	from /home/travis/build/merit-gem/merit/vendor/bundle/ruby/2.3.0/gems/minitest-5.10.3/lib/minitest.rb:687:in `report'
	from /home/travis/build/merit-gem/merit/vendor/bundle/ruby/2.3.0/gems/minitest-5.10.3/lib/minitest.rb:141:in `run'
	from /home/travis/build/merit-gem/merit/vendor/bundle/ruby/2.3.0/gems/railties-5.1.0/lib/rails/test_unit/minitest_plugin.rb:77:in `run'
	from /home/travis/build/merit-gem/merit/vendor/bundle/ruby/2.3.0/gems/minitest-5.10.3/lib/minitest.rb:63:in `block in autorun'
rake aborted!
Command failed with status (1): [ruby -w -I"lib:lib:test" -I"/home/travis/build/merit-gem/merit/vendor/bundle/ruby/2.3.0/gems/rake-12.2.1/lib" "/home/travis/build/merit-gem/merit/vendor/bundle/ruby/2.3.0/gems/rake-12.2.1/lib/rake/rake_test_loader.rb" "test/integration/navigation_test.rb" "test/unit/action_test.rb" "test/unit/base_target_finder_test.rb" "test/unit/merit_unit_test.rb" "test/unit/rule_unit_test.rb" "test/unit/rules_matcher_test.rb" "test/unit/sash_finder_test.rb" "test/unit/sash_test.rb" "test/unit/score_test.rb" "test/unit/target_finder_test.rb" ]
/home/travis/build/merit-gem/merit/vendor/bundle/ruby/2.3.0/gems/rake-12.2.1/exe/rake:27:in `<top (required)>'
/home/travis/.rvm/gems/ruby-2.3.3@global/gems/bundler-1.16.0/lib/bundler/cli/exec.rb:75:in `load'
/home/travis/.rvm/gems/ruby-2.3.3@global/gems/bundler-1.16.0/lib/bundler/cli/exec.rb:75:in `kernel_load'
/home/travis/.rvm/gems/ruby-2.3.3@global/gems/bundler-1.16.0/lib/bundler/cli/exec.rb:28:in `run'
/home/travis/.rvm/gems/ruby-2.3.3@global/gems/bundler-1.16.0/lib/bundler/cli.rb:424:in `exec'
/home/travis/.rvm/gems/ruby-2.3.3@global/gems/bundler-1.16.0/lib/bundler/vendor/thor/lib/thor/command.rb:27:in `run'
/home/travis/.rvm/gems/ruby-2.3.3@global/gems/bundler-1.16.0/lib/bundler/vendor/thor/lib/thor/invocation.rb:126:in `invoke_command'
/home/travis/.rvm/gems/ruby-2.3.3@global/gems/bundler-1.16.0/lib/bundler/vendor/thor/lib/thor.rb:387:in `dispatch'
/home/travis/.rvm/gems/ruby-2.3.3@global/gems/bundler-1.16.0/lib/bundler/cli.rb:27:in `dispatch'
/home/travis/.rvm/gems/ruby-2.3.3@global/gems/bundler-1.16.0/lib/bundler/vendor/thor/lib/thor/base.rb:466:in `start'
/home/travis/.rvm/gems/ruby-2.3.3@global/gems/bundler-1.16.0/lib/bundler/cli.rb:18:in `start'
/home/travis/.rvm/gems/ruby-2.3.3@global/gems/bundler-1.16.0/exe/bundle:30:in `block in <top (required)>'
/home/travis/.rvm/gems/ruby-2.3.3@global/gems/bundler-1.16.0/lib/bundler/friendly_errors.rb:122:in `with_friendly_errors'
/home/travis/.rvm/gems/ruby-2.3.3@global/gems/bundler-1.16.0/exe/bundle:22:in `<top (required)>'
/home/travis/.rvm/gems/ruby-2.3.3@global/bin/bundle:23:in `load'
/home/travis/.rvm/gems/ruby-2.3.3@global/bin/bundle:23:in `<main>'
/home/travis/.rvm/gems/ruby-2.3.3@global/bin/ruby_executable_hooks:15:in `eval'
/home/travis/.rvm/gems/ruby-2.3.3@global/bin/ruby_executable_hooks:15:in `<main>'
Tasks: TOP => default => test
(See full trace by running task with --trace)
The command "bundle exec rake" exited with 1.
cache.2
store build cache
$ bundle clean
0.01s
6.31schanges detected, packing new archive
sh: 1: sw_vers: not found
Done. Your build exited with 1.```

[redtachyons]

Ok, let me check

[redtachyons]

Build failure in 5.1 is unrelated and is a rails bug. build is failing in master as well rails/rails#29022

[redtachyons]

@tute tests are now 💚

[tute]

Thank you so much! 👏 🎉 ❤️ 😃

[yakschuss]

Hey @tute @tachyons - I just updated to 3.0.0 and when I upgraded to rails-5.0.0, this issue still persisted. Any ideas what I can do? I can open a new issue, but felt that this was related.

[tachyons]

This fix is for newer version of rails ( rails 5.14 and above) . And fix is not available in released gem yet

[yakschuss]

OK, I will wait! Thanks :)

[jairovm]

Hi guys, are you planning on doing a release to get this fix soon ?

3.0.1 maybe.

Thanks

[tute]

I'd like to get #279 in before a new release. Anyone willing to wrap up the work started in that PR? Thank you, all! :-)

[redtachyons]

@tute done

[tute]

Thank you, released!