Add migrations versions - Fixes issue 278 #279

nimir · 2017-08-27T10:46:12Z

Fixes issue #278 by adding migrations versions e.g class CreateMeritActions < ActiveRecord::Migration[5.1] instead of current class CreateMeritActions < ActiveRecord::Migration

houndci-bot · 2017-08-27T10:46:22Z

lib/generators/active_record/upgrade_generator.rb

@@ -19,6 +19,12 @@ def copy_migrations_and_model
        end
      end

+      def migration_version
+       if Rails.version.start_with? '5'


Use 2 (not 1) spaces for indentation.
Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.

houndci-bot · 2017-08-27T10:46:22Z

lib/generators/active_record/templates/remove_merit_tables.rb

@@ -1,4 +1,4 @@
-class RemoveMeritTables < ActiveRecord::Migration
+class RemoveMeritTables < ActiveRecord::Migration<%= migration_version %>


unterminated string meets end of file

houndci-bot · 2017-08-27T10:46:22Z

lib/generators/active_record/templates/remove_merit_fields_from_model.rb

@@ -1,4 +1,4 @@
-class RemoveMeritFieldsFrom<%= table_name.camelize %> < ActiveRecord::Migration
+class RemoveMeritFieldsFrom<%= table_name.camelize %> < ActiveRecord::Migration<%= migration_version %>


unexpected token tIDENTIFIER

houndci-bot · 2017-08-27T10:46:22Z

lib/generators/active_record/templates/create_scores_and_points.rb

@@ -1,4 +1,4 @@
-class CreateScoresAndPoints < ActiveRecord::Migration
+class CreateScoresAndPoints < ActiveRecord::Migration<%= migration_version %>


unterminated string meets end of file

houndci-bot · 2017-08-27T10:46:22Z

lib/generators/active_record/templates/create_sashes.rb

@@ -1,4 +1,4 @@
-class CreateSashes < ActiveRecord::Migration
+class CreateSashes < ActiveRecord::Migration<%= migration_version %>


unterminated string meets end of file

houndci-bot · 2017-08-27T10:46:23Z

lib/generators/active_record/templates/add_target_data_to_merit_actions.rb

@@ -1,5 +1,6 @@
-class AddTargetDataToMeritActions < ActiveRecord::Migration
+class AddMeritFieldsTo<%= table_name.camelize %> < ActiveRecord::Migration<%= migration_version %>


unexpected token tIDENTIFIER

houndci-bot · 2017-08-27T10:46:23Z

lib/generators/active_record/templates/add_merit_fields_to_model.rb

@@ -1,4 +1,4 @@
-class AddMeritFieldsTo<%= table_name.camelize %> < ActiveRecord::Migration
+class AddMeritFieldsTo<%= table_name.camelize %> < ActiveRecord::Migration<%= migration_version %>


unexpected token tIDENTIFIER

houndci-bot · 2017-08-27T10:46:23Z

lib/generators/active_record/remove_generator.rb

+         "[#{Rails::VERSION::MAJOR}.#{Rails::VERSION::MINOR}]"
+       end
+      end
+


Extra empty line detected at class body end.

houndci-bot · 2017-08-27T10:46:23Z

lib/generators/active_record/remove_generator.rb

@@ -21,6 +21,13 @@ def copy_migrations_and_model
          "db/migrate/remove_merit_fields_from_#{table_name}.rb"
        )
      end
+
+      def migration_version
+       if Rails.version.start_with? '5'


Use 2 (not 1) spaces for indentation.
Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.

houndci-bot · 2017-08-27T10:46:23Z

lib/generators/active_record/merit_generator.rb

+         "[#{Rails::VERSION::MAJOR}.#{Rails::VERSION::MINOR}]"
+       end
+      end
+


Extra empty line detected at class body end.

houndci-bot · 2017-08-27T10:46:24Z

lib/generators/active_record/upgrade_generator.rb

@@ -19,6 +19,12 @@ def copy_migrations_and_model
        end
      end

+      def migration_version
+       if Rails.version.start_with? '5'


Use 2 (not 1) spaces for indentation.
Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.

houndci-bot · 2017-08-27T10:46:24Z

lib/generators/active_record/templates/remove_merit_tables.rb

@@ -1,4 +1,4 @@
-class RemoveMeritTables < ActiveRecord::Migration
+class RemoveMeritTables < ActiveRecord::Migration<%= migration_version %>


unterminated string meets end of file

houndci-bot · 2017-08-27T10:46:24Z

lib/generators/active_record/templates/remove_merit_fields_from_model.rb

@@ -1,4 +1,4 @@
-class RemoveMeritFieldsFrom<%= table_name.camelize %> < ActiveRecord::Migration
+class RemoveMeritFieldsFrom<%= table_name.camelize %> < ActiveRecord::Migration<%= migration_version %>


unexpected token tIDENTIFIER

houndci-bot · 2017-08-27T10:46:24Z

lib/generators/active_record/templates/create_scores_and_points.rb

@@ -1,4 +1,4 @@
-class CreateScoresAndPoints < ActiveRecord::Migration
+class CreateScoresAndPoints < ActiveRecord::Migration<%= migration_version %>


unterminated string meets end of file

houndci-bot · 2017-08-27T10:46:24Z

lib/generators/active_record/templates/create_sashes.rb

@@ -1,4 +1,4 @@
-class CreateSashes < ActiveRecord::Migration
+class CreateSashes < ActiveRecord::Migration<%= migration_version %>


unterminated string meets end of file

houndci-bot · 2017-08-27T10:46:25Z

lib/generators/active_record/templates/add_merit_fields_to_model.rb

@@ -1,4 +1,4 @@
-class AddMeritFieldsTo<%= table_name.camelize %> < ActiveRecord::Migration
+class AddMeritFieldsTo<%= table_name.camelize %> < ActiveRecord::Migration<%= migration_version %>


unexpected token tIDENTIFIER

houndci-bot · 2017-08-27T10:46:25Z

lib/generators/active_record/remove_generator.rb

+         "[#{Rails::VERSION::MAJOR}.#{Rails::VERSION::MINOR}]"
+       end
+      end
+


Extra empty line detected at class body end.

houndci-bot · 2017-08-27T10:46:25Z

lib/generators/active_record/remove_generator.rb

@@ -21,6 +21,13 @@ def copy_migrations_and_model
          "db/migrate/remove_merit_fields_from_#{table_name}.rb"
        )
      end
+
+      def migration_version
+       if Rails.version.start_with? '5'


Use 2 (not 1) spaces for indentation.
Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.

houndci-bot · 2017-08-27T10:46:25Z

lib/generators/active_record/merit_generator.rb

@@ -16,6 +16,13 @@ def copy_migrations_and_model
        migration_template 'add_merit_fields_to_model.rb',
                           "db/migrate/add_merit_fields_to_#{table_name}.rb"
      end
+
+      def migration_version
+       if Rails.version.start_with? '5'


Use 2 (not 1) spaces for indentation.
Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.

Same thing about unneeded condition (and elsewhere)

houndci-bot · 2017-08-27T10:46:25Z

lib/generators/active_record/install_generator.rb

+         "[#{Rails::VERSION::MAJOR}.#{Rails::VERSION::MINOR}]"
+       end
+      end
+


Extra empty line detected at class body end.

tute

Thank you, @nimir! Left a few comments that apply to all migrations. This is looking good! ❤️

tute · 2017-08-28T15:24:07Z

lib/generators/active_record/install_generator.rb

+      def migration_version
+       if Rails.version.start_with? '5'
+         "[#{Rails::VERSION::MAJOR}.#{Rails::VERSION::MINOR}]"
+       end


Thank you, Nimir! We can assume we are always on 5, as master only targets that version. Until we have Rails 6, we shouldn't need this conditional.

alright, thought we needed backward compatibility with older rails versions! but yeah, if master is only for Rails > 5 then we can skip the check!

tute · 2017-08-28T15:24:37Z

lib/generators/active_record/merit_generator.rb

@@ -16,6 +16,13 @@ def copy_migrations_and_model
        migration_template 'add_merit_fields_to_model.rb',
                           "db/migrate/add_merit_fields_to_#{table_name}.rb"
      end
+
+      def migration_version
+       if Rails.version.start_with? '5'


Same thing about unneeded condition (and elsewhere)

tute · 2017-10-17T13:06:12Z

Ping @nimir! Thank you for your work. ❤️

tute · 2018-01-25T14:57:30Z

Closing in favor of #284. Thanks for your work!

nimir added 2 commits August 27, 2017 13:42

added migration_version method

a9157b4

added migration_version to templates

7e2685f

houndci-bot reviewed Aug 27, 2017

View reviewed changes

merit-gem deleted a comment from houndci-bot Aug 28, 2017

tute reviewed Aug 28, 2017

View reviewed changes

tute mentioned this pull request Jan 24, 2018

Run action controller load hook only once #282

Merged

redtachyons mentioned this pull request Jan 25, 2018

Add migration version to active record migrations #284

Merged

tute closed this Jan 25, 2018

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add migrations versions - Fixes issue 278 #279

Add migrations versions - Fixes issue 278 #279

nimir commented Aug 27, 2017 •

edited

Loading

houndci-bot Aug 27, 2017

houndci-bot Aug 27, 2017

houndci-bot Aug 27, 2017

houndci-bot Aug 27, 2017

houndci-bot Aug 27, 2017

houndci-bot Aug 27, 2017

houndci-bot Aug 27, 2017

houndci-bot Aug 27, 2017

houndci-bot Aug 27, 2017

houndci-bot Aug 27, 2017

houndci-bot Aug 27, 2017

houndci-bot Aug 27, 2017

houndci-bot Aug 27, 2017

houndci-bot Aug 27, 2017

houndci-bot Aug 27, 2017

houndci-bot Aug 27, 2017

houndci-bot Aug 27, 2017

houndci-bot Aug 27, 2017

houndci-bot Aug 27, 2017

tute Aug 28, 2017

houndci-bot Aug 27, 2017

tute left a comment •

edited

Loading

tute Aug 28, 2017

nimir Aug 29, 2017

tute Aug 28, 2017

tute commented Oct 17, 2017

tute commented Jan 25, 2018

		@@ -1,4 +1,4 @@
		class RemoveMeritTables < ActiveRecord::Migration
		class RemoveMeritTables < ActiveRecord::Migration<%= migration_version %>

		@@ -1,4 +1,4 @@
		class RemoveMeritFieldsFrom<%= table_name.camelize %> < ActiveRecord::Migration
		class RemoveMeritFieldsFrom<%= table_name.camelize %> < ActiveRecord::Migration<%= migration_version %>

		@@ -1,4 +1,4 @@
		class CreateScoresAndPoints < ActiveRecord::Migration
		class CreateScoresAndPoints < ActiveRecord::Migration<%= migration_version %>

		@@ -1,4 +1,4 @@
		class CreateSashes < ActiveRecord::Migration
		class CreateSashes < ActiveRecord::Migration<%= migration_version %>

		@@ -1,5 +1,6 @@
		class AddTargetDataToMeritActions < ActiveRecord::Migration
		class AddMeritFieldsTo<%= table_name.camelize %> < ActiveRecord::Migration<%= migration_version %>

Add migrations versions - Fixes issue 278 #279

Add migrations versions - Fixes issue 278 #279

Conversation

nimir commented Aug 27, 2017 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

tute left a comment • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

tute commented Oct 17, 2017

tute commented Jan 25, 2018

nimir commented Aug 27, 2017 •

edited

Loading

tute left a comment •

edited

Loading