Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: aligned powered by text in search popup #270

Merged
merged 2 commits into from
Oct 27, 2022
Merged

fix: aligned powered by text in search popup #270

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9030488
fix: aligned powered by text in search popup
bhanuloshali1995 Oct 18, 2022
898ca0c
Update MeiliSearchBox.vue
bhanuloshali1995 Oct 27, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions MeiliSearchBox.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -207,8 +207,9 @@ dark-input()
// Footer
.docs-searchbar-footer
display flex
justify-content space-between
align-items center
justify-content flex-end
align-items center
column-gap 10px
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is still a gap between the text and the logo. I think if we just remove all these lines, it works

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It won't work if we remove all these lines. The issue was because of justify-content space-between.

The little space is because of column-gap 10px. I don't know if it would look good if all the space is removed but if you want 0 space let me know. I'll remove the 10px gap b/w the text and logo.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you remove display flex as well? I tried it locally and it seems to work

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Screenshot 2022-10-27 at 11 16 21

Screenshot 2022-10-27 at 11 16 42

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, flex was there. I have updated the PR. Thanks.

.docs-searchbar-footer-logo
margin-bottom -4px
.dsb-cursor .docs-searchbar-suggestion--content
Expand Down