fix: aligned powered by text in search popup #270
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bidoubiwa
suggested changes
Oct 24, 2022
MeiliSearchBox.vue
Outdated
Comment on lines
209
to
212
| display flex | ||
| justify-content space-between | ||
| align-items center | ||
| justify-content flex-end | ||
| align-items center | ||
| column-gap 10px |
There was a problem hiding this comment.
There is still a gap between the text and the logo. I think if we just remove all these lines, it works
There was a problem hiding this comment.
It won't work if we remove all these lines. The issue was because of justify-content space-between.
The little space is because of column-gap 10px. I don't know if it would look good if all the space is removed but if you want 0 space let me know. I'll remove the 10px gap b/w the text and logo.
There was a problem hiding this comment.
Did you remove display flex as well? I tried it locally and it seems to work
There was a problem hiding this comment.
Oh, flex was there. I have updated the PR. Thanks.
Removing all the flex related properties
|
bors merge |
|
bors r- |
|
bors merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
Related issue
Fixes #269
What does this PR do?
PR checklist
Please check if your PR fulfills the following requirements:
Thank you so much for contributing to Meilisearch!