Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat trait to make clients customizable #459

Merged
merged 109 commits into from
Apr 10, 2024
Merged

Feat trait to make clients customizable #459

merged 109 commits into from
Apr 10, 2024

Conversation

shimatar0
Copy link
Contributor

@shimatar0 shimatar0 commented Apr 4, 2023 •
edited by irevoire
Loading

Pull Request

Related issue

Fixes #452

What does this PR do?

  • This is a WIP state and I'll add it next time.
  • There are still many problems to be solved. I will comment on the code.

PR checklist

Please check if your PR fulfills the following requirements:

  • Does this PR fix an existing issue, or have you listed the changes applied in the PR description (and why they are needed)?
  • Have you read the contributing guidelines?
  • Have you made sure that the title is accurate and descriptive of the changes?
  • Fix the settings macro
  • Fix compiling without default features

Thank you so much for contributing to Meilisearch!

@shimatar0 shimatar0 marked this pull request as draft April 4, 2023 16:14
@shimatar0 shimatar0 mentioned this pull request Apr 4, 2023
Closed
3 tasks
shimatar0
shimatar0 commented Apr 4, 2023
View reviewed changes
src/request.rs Outdated Show resolved Hide resolved
shimatar0
shimatar0 commented Apr 4, 2023
View reviewed changes
src/tasks.rs Outdated Show resolved Hide resolved
@shimatar0

This comment was marked as resolved.

Sign in to view
shimatar0
shimatar0 commented Apr 5, 2023
View reviewed changes
src/client.rs Outdated Show resolved Hide resolved
@shimatar0

This comment was marked as resolved.

Sign in to view
shimatar0 added 18 commits April 7, 2023 00:12
@shimatar0
Fix return value
d1e421e
@shimatar0
Add cliant structure correspondence specifying IsahcClient
430630e
@shimatar0
Remove unnecessary specification
2dffdb9
@shimatar0
Fix typo, unnecessary comment out
9be62eb
@shimatar0
Fix macro to generate IndexConfig
5c4d3db
@shimatar0
Fix task_info test
0fc300b
@shimatar0
Fix typo
32d3ed0
@shimatar0
Fix test
1aab7e9
@shimatar0
Fix settings.rs in example
b5b8eb1
@shimatar0
Change request mod to public
a5c4ce9
@shimatar0
Add stream_request to HttpClient
b12acce
@shimatar0
Add send and sync trait
e2cd659
@shimatar0
Change request method calls in setting.rs to use http_client
9ca8c74
@shimatar0
Change request method calls in client.rs to use http_client
b679f69
@shimatar0
Change request method calls in indexes.rs to use http_client
86e5e91
@shimatar0
Change request method calls in dumps.rs to use http_client
a2384d3
@shimatar0
Fix async_trait to have Send trait for wasm32 build
a27ec24
@shimatar0
Fix async trait in index config and macro code
d923605
@shimatar0 shimatar0 changed the title [WIP] Feat trait to make clients customizable Feat trait to make clients customizable Jun 18, 2023
@gibbz00
Copy link

gibbz00 commented Sep 22, 2023 •
edited
Loading

Is there anything I can do to get this PR past the finishing line? I'm open to rebasing this with master and squashing relevant commits if it helps with reviewability.

@gibbz00 gibbz00 mentioned this pull request Sep 24, 2023
Closed
@curquiza curquiza added the breaking-change The related changes are breaking for the users label Sep 27, 2023
@aumetra aumetra mentioned this pull request Oct 25, 2023
Open
@irevoire irevoire force-pushed the customize-http-client branch from 2b690a2 to 97e53f3 Compare April 9, 2024 09:32
@irevoire irevoire force-pushed the customize-http-client branch from fa4062f to dfeea76 Compare April 9, 2024 14:03
@irevoire irevoire marked this pull request as ready for review April 9, 2024 14:04
irevoire
irevoire requested changes Apr 10, 2024
View reviewed changes
examples/cli-app-with-reqwest/src/main.rs Outdated Show resolved Hide resolved
src/client.rs Show resolved Hide resolved
src/client.rs Outdated Show resolved Hide resolved
irevoire
irevoire approved these changes Apr 10, 2024
View reviewed changes
Copy link
Member

@irevoire irevoire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for your work @shimatar0 and sorry for the huge delay 🙈

bors merge

@irevoire irevoire requested a review from bidoubiwa April 10, 2024 12:53
@curquiza curquiza removed the request for review from bidoubiwa April 10, 2024 12:56
@curquiza curquiza merged commit 80f6326 into meilisearch:main Apr 10, 2024
6 of 7 checks passed
@shimatar0 shimatar0 deleted the customize-http-client branch April 10, 2024 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bidoubiwa bidoubiwa bidoubiwa requested changes

@irevoire irevoire irevoire approved these changes

Assignees
No one assigned
Labels
breaking-change The related changes are breaking for the users enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Let users customize their web client
6 participants
@shimatar0 @novacrazy @irevoire @gibbz00 @bidoubiwa @curquiza