Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Let users customize their web client #452

Closed
irevoire opened this issue Mar 28, 2023 · 1 comment · Fixed by #459
Closed

Let users customize their web client #452

irevoire opened this issue Mar 28, 2023 · 1 comment · Fixed by #459
Labels
good first issue Good for newcomers

Comments

@irevoire
Copy link
Member

Following: #426 (comment)

It would be nice to make the web client customizable, i.e:

  • Add a feature flag to get rid of ishac (by default, we should continue to use it)
  • Add a new_with_client function to create a Client with anything that implements request
@irevoire irevoire added the good first issue Good for newcomers label Mar 28, 2023
This was referenced Mar 31, 2023
Closed
Merged
@carlosb1
Copy link
Contributor

I could try to do a proposal to simplify the constructor... I can try a builder pattern or factory... but I could not use the draft PR... I would need to do a new impl... Is it fine ?
Some refs:
https://rust-unofficial.github.io/patterns/patterns/creational/builder.html

@gibbz00 gibbz00 mentioned this issue Sep 24, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
2 participants
@carlosb1 @irevoire