Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix "CsvInBatchesWithDelimiter" test #613

Merged
merged 1 commit into from
Jan 22, 2024
Merged

Fix "CsvInBatchesWithDelimiter" test #613

merged 1 commit into from
Jan 22, 2024

Conversation

aivchen
Copy link
Contributor

@aivchen aivchen commented Jan 21, 2024

Pull Request

What does this PR do?

  • in the old implementation willReturnCallback() wasn't called due to willReturn() in the end. I removed willReturn() and fixed the test.

PR checklist

Please check if your PR fulfills the following requirements:

  • Does this PR fix an existing issue, or have you listed the changes applied in the PR description (and why they are needed)?
  • Have you read the contributing guidelines?
  • Have you made sure that the title is accurate and descriptive of the changes?

Thank you so much for contributing to Meilisearch!

@aivchen aivchen mentioned this pull request Jan 21, 2024
Merged
3 tasks
@norkunas
Copy link
Collaborator

bors merge

@meili-bors meili-bors
Copy link
Contributor

meili-bors bot commented Jan 22, 2024

Build succeeded:

@meili-bors meili-bors bot merged commit f07267b into meilisearch:main Jan 22, 2024
9 checks passed
@norkunas
Copy link
Collaborator

Thanks @aivchen

@aivchen aivchen deleted the fix-test branch January 22, 2024 11:43
@curquiza curquiza added the bug Something isn't working label Jan 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@norkunas norkunas norkunas approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@aivchen @norkunas @curquiza