Merge #613

613: Fix "CsvInBatchesWithDelimiter"  test r=norkunas a=aivchen

# Pull Request

## What does this PR do?
- in the old implementation `willReturnCallback()` wasn't called due to `willReturn()` in the end. I removed `willReturn()` and fixed the test.

## PR checklist
Please check if your PR fulfills the following requirements:
- [x] Does this PR fix an existing issue, or have you listed the changes applied in the PR description (and why they are needed)?
- [x] Have you read the contributing guidelines?
- [x] Have you made sure that the title is accurate and descriptive of the changes?

Thank you so much for contributing to Meilisearch!


Co-authored-by: andrew <and.ivchenkov@gmail.com>

tests/Endpoints/DocumentsTest.php

@@ -306,7 +306,6 @@ public function testAddDocumentsCsvInBatches(): void
 
     public function testAddDocumentsCsvInBatchesWithDelimiter(): void
     {
-        $matcher = $this->exactly(2);
         $documentCsv = 'id;title'.PHP_EOL;
         $documentCsv .= '888221515;Young folks'.PHP_EOL;
         $documentCsv .= '235115704;Mister Klein'.PHP_EOL;
@@ -317,22 +316,22 @@ public function testAddDocumentsCsvInBatchesWithDelimiter(): void
             ->disableOriginalConstructor()
             ->getMock();
 
-        $index->expects($matcher)
+        $index->expects($this->exactly(2))
               ->method('addDocumentsCsv')
-              ->willReturnCallback(function (string $param) use ($matcher): void {
+              ->willReturnCallback(function (string $documents, $primaryKey, $delimiter): void {
+                  static $invocation = 0;
                   // withConsecutive has no replacement https://github.com/sebastianbergmann/phpunit/issues/4026
-                  switch ($matcher->numberOfInvocations()) {
+                  switch (++$invocation) {
                       case 1:
-                          $this->assertEquals($param, ["id;title\n888221515;Young folks", null, ';']);
+                          static::assertSame(["id;title\n888221515;Young folks", null, ';'], [$documents, $primaryKey, $delimiter]);
                           break;
                       case 2:
-                          $this->assertEquals($param, ["id;title\n235115704;Mister Klein", null, ';']);
+                          static::assertSame(["id;title\n235115704;Mister Klein", null, ';'], [$documents, $primaryKey, $delimiter]);
                           break;
                       default:
                           self::fail();
                   }
-              })
-              ->willReturn([], []);
+              });
 
         $index->addDocumentsCsvInBatches($documentCsv, 1, null, ';');
     }