Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat support content encoding #570

Merged
merged 24 commits into from
Sep 23, 2024
Merged

Conversation

Ja7ad
Copy link
Collaborator

@Ja7ad Ja7ad commented Aug 23, 2024

Pull Request

Related issue

Fixes #566

What does this PR do?

This PR support content encoding gzip, deflate, brotli.

client := meilisearch.New("127.0.0.1:7700", meilisearch.WithContentEncoding(meilisearch.GzipEncoding, meilisearch.DefaultCompression))

Note: This PR is not breaking changes.

PR checklist

Please check if your PR fulfills the following requirements:

  • Does this PR fix an existing issue, or have you listed the changes applied in the PR description (and why they are needed)?
  • Have you read the contributing guidelines?
  • Have you made sure that the title is accurate and descriptive of the changes?

Thank you so much for contributing to Meilisearch!

@Ja7ad Ja7ad force-pushed the feat/content-encoding branch from 9c2fc3d to 578ea94 Compare August 25, 2024 18:57
@Ja7ad Ja7ad force-pushed the feat/content-encoding branch from 8f2e04e to 24cbcb4 Compare August 25, 2024 19:57
@Ja7ad Ja7ad marked this pull request as ready for review August 26, 2024 05:19
Copy link

codecov bot commented Aug 26, 2024

Codecov Report

Attention: Patch coverage is 93.52941% with 11 lines in your changes missing coverage. Please review.

Project coverage is 87.27%. Comparing base (63161f2) to head (5ecb35a).
Report is 25 commits behind head on main.

Files with missing lines Patch % Lines
client.go 69.44% 7 Missing and 4 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #570      +/-   ##
==========================================
+ Coverage   86.72%   87.27%   +0.55%     
==========================================
  Files          11       12       +1     
  Lines        2041     2193     +152     
==========================================
+ Hits         1770     1914     +144     
- Misses        165      170       +5     
- Partials      106      109       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Ja7ad
Copy link
Collaborator Author

Ja7ad commented Sep 18, 2024

bors merge

meili-bors bot added a commit that referenced this pull request Sep 18, 2024
570: Feat support content encoding  r=Ja7ad a=Ja7ad

# Pull Request

## Related issue
Fixes #566 

## What does this PR do?

This PR support content encoding `gzip`, `deflate`, `brotli`.


```go
client := meilisearch.New("127.0.0.1:7700", meilisearch.WithContentEncoding(meilisearch.GzipEncoding, meilisearch.DefaultCompression))
```

Note: This PR is not breaking changes.

## PR checklist
Please check if your PR fulfills the following requirements:
- [x] Does this PR fix an existing issue, or have you listed the changes applied in the PR description (and why they are needed)?
- [x] Have you read the contributing guidelines?
- [x] Have you made sure that the title is accurate and descriptive of the changes?

Thank you so much for contributing to Meilisearch!


Co-authored-by: Javad <ja7ad@live.com>
Co-authored-by: Javad Rajabzadeh <ja7ad@live.com>
Copy link
Contributor

meili-bors bot commented Sep 18, 2024

This PR was included in a batch that successfully built, but then failed to merge into main. It will not be retried.

Additional information:

{"message":"At least 1 approving review is required by reviewers with write access.","documentation_url":"https://docs.github.com/articles/about-protected-branches","status":"422"}

@curquiza curquiza added the enhancement New feature or request label Sep 23, 2024
Copy link
Member

@curquiza curquiza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @Ja7ad

bors merge

Copy link
Contributor

meili-bors bot commented Sep 23, 2024

@meili-bors meili-bors bot merged commit 2ee4206 into meilisearch:main Sep 23, 2024
8 checks passed
meili-bors bot added a commit that referenced this pull request Oct 28, 2024
584: Update version for the next release (v0.29.0) r=brunoocasali a=meili-bot

_This PR is auto-generated._

The automated script updates the version of meilisearch-go to a new version: "v0.29.0"

--- Changelogs 👇 ---

## ⚠️ Breaking changes (experimental feature)

* `embedder` is now mandatory everywhere - Ensure compatibility with [Meilisearch v1.11](https://github.com/meilisearch/meilisearch/releases/tag/v1.11.0) by `@/Kerollmops`

## 🚀 Enhancements

* Add Embedder.URL (#568) `@/polyfloyd`
* Add multi-search federation (#563) `@/polyfloyd`
* Feat support content encoding  (#570) `@/Ja7ad`
* Support experimental manager (#572) `@/A7bari`
* Feat Language settings & search parameter (#580) `@J/a7ad`
* Feat support retry pattern on status code 502, 503, 504 (#581) `@/Ja7ad`

Thanks again to `@/A7bari,` `@/Ja7ad,` `@/Kerollmops`  and `@/polyfloyd!` 🎉



Co-authored-by: meili-bot <74670311+meili-bot@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support content encoding gzip, deflate and brotli
2 participants