Add Embedder.URL #568
Merged
Add Embedder.URL #568
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ja7ad
requested changes
Aug 22, 2024
polyfloyd
force-pushed
the
add-embedder-url
branch
from
5e1db33 to
9ffd104
Compare
Ja7ad
approved these changes
Aug 22, 2024
|
Can this be merged now? |
brunoocasali
approved these changes
Sep 15, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #568 +/- ##
=======================================
Coverage 86.73% 86.73%
=======================================
Files 11 11
Lines 2043 2043
=======================================
Hits 1772 1772
Misses 165 165
Partials 106 106 ☔ View full report in Codecov by Sentry. |
meili-bors bot
added a commit
that referenced
this pull request
Oct 28, 2024
584: Update version for the next release (v0.29.0) r=brunoocasali a=meili-bot _This PR is auto-generated._ The automated script updates the version of meilisearch-go to a new version: "v0.29.0" --- Changelogs 👇 --- ##⚠️ Breaking changes (experimental feature) * `embedder` is now mandatory everywhere - Ensure compatibility with [Meilisearch v1.11](https://github.com/meilisearch/meilisearch/releases/tag/v1.11.0) by `@/Kerollmops` ## 🚀 Enhancements * Add Embedder.URL (#568) `@/polyfloyd` * Add multi-search federation (#563) `@/polyfloyd` * Feat support content encoding (#570) `@/Ja7ad` * Support experimental manager (#572) `@/A7bari` * Feat Language settings & search parameter (#580) `@J/a7ad` * Feat support retry pattern on status code 502, 503, 504 (#581) `@/Ja7ad` Thanks again to `@/A7bari,` `@/Ja7ad,` `@/Kerollmops` and `@/polyfloyd!` 🎉 Co-authored-by: meili-bot <74670311+meili-bot@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
What does this PR do?
Partial fix for #576
The documentation for the Ollama Embedder states that there is an
urlfield that can be used to specify how Ollama can be reached. However, this field is not present yet in this client library.See: https://www.meilisearch.com/docs/learn/experimental/vector_search#generate-auto-embeddings
PR checklist
Please check if your PR fulfills the following requirements: