Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update getting_started code-samples #328

Merged
merged 3 commits into from
Jul 4, 2023
Merged

Update getting_started code-samples #328

merged 3 commits into from
Jul 4, 2023

Conversation

meili-bot
Copy link
Contributor

This PR is auto-generated.
Update the code-samples.meilisearch.yml according to the documentation issue.
The api_key field is missing in the instantiation of the client in the getting started samples.
Add aSampleMasterKey as the api_key.
cURL example:

    curl \
  -X POST 'http://localhost:7700/indexes/movies/documents?primaryKey=id' \
  -H 'Content-Type: application/json' \
  -H 'Authorization: Bearer aSampleMasterKey' \
  --data-binary @movies.json

@meili-bot meili-bot added documentation Improvements or additions to documentation skip-changelog The PR will not appear in the release changelogs labels Jul 3, 2023
@ahmednfwela ahmednfwela self-assigned this Jul 3, 2023
@ahmednfwela ahmednfwela marked this pull request as ready for review July 3, 2023 18:41
ahmednfwela
ahmednfwela reviewed Jul 3, 2023
View reviewed changes
.code-samples.meilisearch.yaml
dependencies:
meilisearch: ^0.3.1
```bash
dart pub add meilisearch
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we rely on the dart cli to get the latest version instead of maintaining it manually

@ahmednfwela
Copy link
Collaborator

note that I couldn't find the dart sdk in the getting started section
image

@ahmednfwela ahmednfwela requested review from alallema and bidoubiwa July 3, 2023 18:46
@brunoocasali
Copy link
Member

Yeah @ahmednfwela I'm not sure why it is not showing up :|

brunoocasali
brunoocasali approved these changes Jul 4, 2023
View reviewed changes
Copy link
Member

@brunoocasali brunoocasali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bors merge

@meili-bors
Copy link
Contributor

meili-bors bot commented Jul 4, 2023

Build succeeded:

@meili-bot meili-bot merged commit e24aeda into main Jul 4, 2023
@meili-bot meili-bot deleted the meili-bot/getting-started-code-samples branch July 4, 2023 19:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ahmednfwela ahmednfwela ahmednfwela left review comments

@brunoocasali brunoocasali brunoocasali approved these changes

@alallema alallema Awaiting requested review from alallema

@bidoubiwa bidoubiwa Awaiting requested review from bidoubiwa

Assignees

@ahmednfwela ahmednfwela

Labels
documentation Improvements or additions to documentation skip-changelog The PR will not appear in the release changelogs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@meili-bot @ahmednfwela @brunoocasali