Python code hangs - needs the 'aSampleMasterKey' API key

[RGGH]

https://www.meilisearch.com/docs/learn/getting_started/quick_start

The Python script never completes with the copy/paste code, might confuse beginners!

should read:

client = meilisearch.Client('http://127.0.0.1:7700', 'aSampleMasterKey')

not client = meilisearch.Client('http://localhost:7700')

[guimachiavelli]

Hi @RGGH! Thanks for creating this issue!

@meilisearch/integration-team, what do you think? None of the Quick start SDK samples use aSampleMasterKey, which means SDK users following this tutorial might stumble on the same problem.

[brunoocasali]

@alallema does the python SDK allow starting the client with no master key?

[bidoubiwa]

I think every SDK's code-sample should be updated to add aSimpleMasterKey to it client instantiation

This is the curl code-sample

curl \
  -X POST 'http://localhost:7700/indexes/movies/documents?primaryKey=id' \
  -H 'Content-Type: application/json' \
  -H 'Authorization: Bearer aSampleMasterKey' \
  --data-binary @movies.json

These is the JS for example:

const client = new MeiliSearch({ host: 'http://localhost:7700' })
client.index('movies').addDocuments(movies)
  .then((res) => console.log(res))

From those I checked, none of the languages include that apiKey in their getting started code-samples.

[brunoocasali]

I don't get it sorry :/ We support the integrations to be instantiated without a key, like meilisearch itself. If this is not a bug on the Python side, why should we update the code samples?

[bidoubiwa]

In the flow of the quickstart guide, during the launch step, we ask the user to add a masterKey

When arriving in the add documents sections, if you copy paste the cURL sample it works as it contains the master key, but any other SDK sample wont work as they don't contain it.

See screen with python, but it's the same for all other languages except cURL

[alallema]

@alallema does the python SDK allow starting the client with no master key?

Yes, like almost SDK I think.

If this is not a bug on the Python side, why should we update the code samples?

Perfect!

[brunoocasali]

All the PRs were closed, so no more missing keys in the quickstart guide. @guimachiavelli I'll close this, but I think we need to trigger a new docs version to see it in production :)

Thanks @bidoubiwa and @RGGH for the report 🎉