Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test on python 3.12 #69

Closed
wants to merge 7 commits into from
Closed

Test on python 3.12 #69

wants to merge 7 commits into from

Conversation

ziw-liu
Copy link
Collaborator

@ziw-liu ziw-liu commented Feb 24, 2024

PyTorch 2.2.1 added python 3.12 support.

@ziw-liu ziw-liu added maintenance Maintenance work CI Continuous integration labels Feb 24, 2024
@ziw-liu
Copy link
Collaborator Author

ziw-liu commented Feb 24, 2024

Waiting for a MONAI fix for Project-MONAI/MONAI#7491.

Copy link
Contributor

@edyoshikun edyoshikun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Currently getting errors with matplotlib 3.9.0.

Traceback (most recent call last):
  File "/hpc/mydata/eduardo.hirata/.conda/envs/py312/bin/viscy", line 5, in <module>
    from viscy.cli.cli import main
  File "/hpc/mydata/eduardo.hirata/.conda/envs/py312/lib/python3.12/site-packages/viscy/cli/cli.py", line 13, in <module>
    from viscy.light.engine import VSUNet
  File "/hpc/mydata/eduardo.hirata/.conda/envs/py312/lib/python3.12/site-packages/viscy/light/engine.py", line 9, in <module>
    from matplotlib.cm import get_cmap
ImportError: cannot import name 'get_cmap' from 'matplotlib.cm' (/hpc/mydata/eduardo.hirata/.conda/envs/py312/lib/python3.12/site-packages/matplotlib/cm.py)

@ziw-liu
Copy link
Collaborator Author

ziw-liu commented Jun 12, 2024

Closing in favor of #87

@ziw-liu ziw-liu mentioned this pull request Jun 12, 2024
@ziw-liu ziw-liu deleted the py312 branch June 12, 2024 22:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI Continuous integration maintenance Maintenance work
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants