-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Compatibility issues #83
Comments
@edyoshikun can you confirm the details for the neuromast model and comment on compatibility requirements of the mantis revision? |
Correct! Neuromast model was trained with the current HEAD of the main. I confirm. |
Hi @ziw-liu We'd fine-tune the VSCyto3D model with data acquired on Mantis as we discussed at the lab meeting yesterday. Please start a PR with changes that enable training of both VSCyto3D and VSNeuromast models with the main. This PR should be a priority since we need it to iterate on the models for mantis Fig. 1 next. It seems like 2D FCMAE branch will require development such that the weights are compatible with the main. I don't follow this point, can you point to a few lines of code to illustrate? This can be the second PR. Thanks for iterating quickly on these. |
I think @edyoshikun is already training these models without needing code changes. (Recall that VSCyto3D and VSNeuromast are the same architecture trained on different data.) The incompatibility I mentioned in OP for VSCyto3D is between the old config files we published (e.g. on zenodo for the mantis preprint) and the current code base. This is a minor issue since that zenodo record points to a pinned version of VisCy that works properly with the files. |
The network module changed, among other things. For example: |
@ziw-liu How about the following order of operation?
|
The VSCyto2D models are made from the FCMAE class for both pre-training and fine-tuning. My suggestion is:
|
@ziw-liu. This order of operation makes sense to me. Are you renaming what we thought of release 0.2.0 as 0.1.0? Totally fine to call the next release 0.1.0. Please update the milestone for clarity if you mean something else. |
Let's also update the Readme.md and add the preprint link here as well. |
|
The models we report in the preprints were trained with different versions of the codebase:
The VSCyto3D weights can be provided with an updated config file, while #71 will need to add API changes to separate 2D model building and also change config files accordingly before merging.
The text was updated successfully, but these errors were encountered: