Use Ubuntu 22 as Hosted Runner in Github CI #123
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There is a newer hosted runner Ubuntu image for github-actions - ubuntu-20.04 -> ubuntu-22.04
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: razo7 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
When Golang is 1.20 and hosted OS in CI is Ubuntu-22.04, then we need to set CGO_ENABLED to zero, golang/go#58550, for the controller-gen binary
|
/retest |
|
Nice! Your idea worked @slintes 👏🏻 |
|
/retest |
1 similar comment
|
/retest |
perfect, thx for trying it 👍🏼 /lgtm |
Shai1-Levi
pushed a commit
to Shai1-Levi/self-node-remediation
that referenced
this pull request
Feb 24, 2025
…ation Separate nm status initalization from update
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up PR to #117 which will overcome the problem with CGO_ENABLED=0 in controller-gen binary, when we update hosted runner Ubuntu image for github-actions -
ubuntu-20.04->ubuntu-22.04.